This repository was archived by the owner on May 4, 2021. It is now read-only.
Ticket28566 rebased on 29591 #345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmathewson
suggested changes
Mar 7, 2019
nmathewson
left a comment
nmathewson
left a comment
There was a problem hiding this comment.
Hi! I've made some small suggestions throughout the code. It's a little tricky to follow, but I think documenting functions will fix that. Also, I'd strongly suggest documenting what exactly each new field should contain. Once that's done you should feel free to merge.
for each relay and for the list of relays when fetching new network statuses. To count the number of times a relay was in a consensus and how many consensuses have been seen. In the test network router status entries don't have document attribute. Part of #28566
juga0
force-pushed
the
ticket28566_rebased_on_29591
branch
from
5cfb716 to
a060738
Compare
Contributor
Author
|
Agree with all suggestions. |
that have been seen for a relay and for the relay list. Part of #28566.
Part of #28566.
for every result that is stored. Part of #28566.
to the state file. To know the total number of consensus seen in the last days. Part of #28566.
Include a KeyValue in each bandwidth line with the number of times the relay has been in a consensus in the past days. Part of #28566.
The total number of consensuses seen in the last days. Part of #28566.
juga0
force-pushed
the
ticket28566_rebased_on_29591
branch
from
a060738 to
d775f42
Compare
used in the bandwidth file, so that it is less confusing and less prone to errors.
juga0
force-pushed
the
ticket28566_rebased_on_29591
branch
from
6b535f9 to
9903b5e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.