Open
Conversation
Owner
|
Thanks for your contribution. I'll take a look soon 😃 |
Owner
|
Let me ask you a question. What did you expected about how this plugin behave if users use this plugin with following options?
Or if you didn't intend such a usage, I think the implementation should handle status about each options in keeping with your expectation. And please write some tests to keep this plugin's decent quality. Thanks 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks for your package.
replaceOriginalis good but it doesn't allow to check the modification before accepting them. It just replace. So, I've made an optionpopupCorrectionthat will display aconfirmdialog. If the user hitokthen, the original text is replaced. This could be nicer by using theNotificationManagerof Atom, but it works.continuethat automatically moves the cursor to the next sentence and run thecorrectfunction. It stops only between paragraphs.M.