POI editor: hide Attributes tab for pending objects#6
Closed
tordans wants to merge 1 commit into
Closed
Conversation
Treat local-only ways, areas, and relations like new nodes: hide the Attributes tab and clamp saved poiTabIndex 2 to Common Tags (0). Add shouldShowAttributesTab, resolvedTabBar, and unit tests for tab resolution across nil, pending, and uploaded selections. Co-authored-by: Tobias <t@tobiasjordans.de>
cursor Bot
pushed a commit
that referenced
this pull request
May 30, 2026
Expose resolvedTabBar for tab index clamping; adopt in viewDidLoad. Supersedes duplicate Attributes-tab logic in draft PR #6. Co-authored-by: Tobias <t@tobiasjordans.de>
Owner
Author
tordans
added a commit
that referenced
this pull request
May 31, 2026
Expose resolvedTabBar for tab index clamping; adopt in viewDidLoad. Supersedes duplicate Attributes-tab logic in draft PR #6. Co-Authored-By: Tobias <t@tobiasjordans.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded
This draft is closed. The same Attributes-tab fix for pending/local geometry is merged into PR #8 along with:
POITabBarControllerTestCaseunit tests (ported from this PR)Please review and test via PR #8 only.
Original description (PR #6)
When editing a pending OSM object (local-only way, area, or relation with a negative
identuntil upload), the POI editor still showed all three tabs—including Attributes—and could restoreUserPrefs.poiTabIndex == 2onto a controller that only had two tabs.Implementation used
shouldShowAttributesTab/resolvedTabBarandPOITabBarControllerTestCase.