Improve OSM note sheet actions and share link#16
Open
tordans wants to merge 1 commit into
Open
Conversation
Style Comment and Resolve as prominent iOS buttons and add an on-page row to share the note URL via the system share sheet. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Als GoMap-Nutzer/in, möchte ich im Hinweis-Fenster klar erkennbare Aktionsbuttons und eine Möglichkeit haben, den Hinweis auf openstreetmap.org zu öffnen, damit ich Kommentare zuverlässig abschicken bzw. Hinweise schließen kann und den Hinweis bei Bedarf im Browser teilen oder öffnen kann.
Aktuell wirken „Comment“ und „Comment & Resolve“ wie einfache Textlinks und sind schwer als primäre Aktionen zu erkennen. Ein Link zum Hinweis auf osm.org ist nur über das wenig sichtbare Teilen-Symbol in der Navigationsleiste erreichbar — nicht direkt auf der Seite.
Implementation notes (by Cursor)
CommentandComment & ResolveinNotesTableViewControllernow use native iOS button styling:UIButton.Configuration.prominentGlass()with capsule corners (consistent with map toolbar buttons)UIButton.Configuration.filled()with medium corner radiusUIActivityViewController) with the note URL ({server}/note/{id}), allowing Safari, copy link, AirDrop, etc.noteId > 0). Brand-new notes that have not yet been uploaded remain disabled (grayed out). The existing nav-bar share button uses the same logic.src/iOS/NotesTableViewController.swiftonly.Testing notes (by @tordans)
openstreetmap.org/note/{id}URL; Open in Safari loads the note page.Made with Cursor
Note
Low Risk
Localized UI and share gating in
NotesTableViewControlleronly; no changes to note upload APIs or authentication.Overview
The OSM note detail sheet now treats Comment and Comment & Resolve as clear primary actions via version-aware
UIButton.Configuration(glass on iOS 26, filled on 15+, blue fallback on older OS), with a fixed 44pt height.Sharing is gated on a persisted OSM id (
noteId > 0) instead of whether the note already has comment history, so brand-new notes stay non-shareable until upload. A new in-list row Open on openstreetmap.org opens the same system share sheet as the nav-bar action; share presentation is centralized inpresentShareSheetwith popover anchoring for both bar buttons and table cells.The update section is modeled with
UpdateSectionRow(comment, share link, directions) so the table grows from two implicit rows to three without magic index numbers.Reviewed by Cursor Bugbot for commit f986494. Bugbot is set up for automated code reviews on this repo. Configure here.