Preserve POI type search until attribute editor closes#1
Closed
tordans wants to merge 2800 commits into
Closed
Conversation
Currently translated at 100.0% (762 of 762 strings) Translation: Go Map!!/App Translate-URL: https://hosted.weblate.org/projects/go-map/app/de/
Currently translated at 33.2% (262 of 788 strings) Translation: Go Map!!/App Translate-URL: https://hosted.weblate.org/projects/go-map/app/tr/
Currently translated at 99.3% (761 of 766 strings) Translation: Go Map!!/App Translate-URL: https://hosted.weblate.org/projects/go-map/app/zh_Hans/
Currently translated at 99.8% (765 of 766 strings) Translation: Go Map!!/App Translate-URL: https://hosted.weblate.org/projects/go-map/app/id/
Currently translated at 51.6% (407 of 788 strings) Translation: Go Map!!/App Translate-URL: https://hosted.weblate.org/projects/go-map/app/tr/
Currently translated at 98.2% (774 of 788 strings) Translation: Go Map!!/App Translate-URL: https://hosted.weblate.org/projects/go-map/app/tr/
Currently translated at 99.3% (783 of 788 strings) Translation: Go Map!!/App Translate-URL: https://hosted.weblate.org/projects/go-map/app/tr/
Currently translated at 100.0% (788 of 788 strings) Translation: Go Map!!/App Translate-URL: https://hosted.weblate.org/projects/go-map/app/tr/
…und recording traces
…licit seconds is missing. Also adds additional aliases for prime and double-prime marks.
Keep the feature picker search query in memory while the POI tab bar modal is open so returning from a mistaken selection does not clear it. Clear the stored query when the modal is dismissed (save, cancel, swipe, or equivalent). The search field clear control still resets the query via the existing text-change path. Co-Authored-By: Tobias <t@tobiasjordans.de>
tordans
force-pushed
the
cursor/preserve-feature-search-until-dismiss-6778
branch
from
9a8de50 to
f1acb64
Compare
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When choosing a feature type from search, returning to the tags screen after a mistaken pick previously left the type picker with an empty search field. The search query is now kept for the whole time the POI attribute editor (tab bar modal) stays open, and is cleared only when that modal is dismissed (save, cancel, interactive dismiss, etc.).
Implementation
POIFeaturePickerViewController: store the current search string in a private static while the user edits; restore it inviewWillAppearand reuse a singlerefreshSearchResultshelper fromsearchBar(_:textDidChange:).POITabBarController: clear the stored string inviewWillDisappearwhen the controller is being dismissed or removed from its parent.The system search field clear control still clears the text through the existing delegate path.
Testing
Manually tested with Xcode Simmulator:
gomap-search.min.mov