Add workflows for video2commons deployment by Amdrel · Pull Request #303 · toolforge/video2commons

Amdrel · 2026-02-06T19:30:30Z

Description

This patch adds GHA workflows for deploying to both the frontend (Toolforge) and encoders (Cloud VPS). This should help allow deployments to be easier for maintainers.

@don-vip I'll take this out of draft mode once we confirm some of the assumptions I'm making.

Changes

Added workflows for deploying v2c updates to the frontend and encoders.
- For now only manual deployments are supported, but there are commented out triggers for deploying on push in case we want to do that.
Remove all minified files from the repository as they are now generated by the workflows prior to deployment.
- Minified files have been added to the .gitignore file as well.
- Because of this, the steps to check and push minified files in ci.yml have been removed. The check job just makes sure the build completes without any errors now.
Added a new script for deploying the frontend to Toolforge named deploy-toolforge.sh.
Renamed deploy.sh to deploy-encoders.sh as there are now two deployment scripts.
Updated the existing deploy-encoders.sh script to return a non-zero exit code if the deployment fails for any workers.
Added an explicit TimeoutStopSec=infinity to the v2ccelery.service service unit to make sure systemd never sends a SIGKILL to the workers before they complete.

Disclaimers

~~The workflow assumes that the SSH key is stored in the V2C_SSH_PRIVATE_KEY secret and uses ed25519. Please let me know if this needs to be changed.~~
- Update: Secret name has been corrected to SSH_PRIVATE_KEY.
I've only tested these workflows on local VMs with act so far, but these environments are not the same as production.

don-vip · 2026-02-06T19:34:47Z

* The workflow assumes that the SSH key is stored in the `V2C_SSH_PRIVATE_KEY` secret and uses ed25519. Please let me know if this needs to be changed.

The secret is simply named SSH_PRIVATE_KEY, otherwise yes, it has been generated using ed25519.

don-vip · 2026-02-06T19:41:38Z

.github/workflows/toolforge-deployment.yml

+  #     - 'package-lock.json'
+  #     - 'package.json'
+  #     - 'utils/deploy-toolforge.sh'
+  #     - 'video2commons-socketio/**'


socketio is its own toolforge project, so we need to remove this line, and duplicate the deploy-toolforge script to have deploy-toolforge-video2commons and deploy-toolforge-video2commons-socketio. We could also add a fourth one for deploy-toolforge-video2commons-test.

Maybe we could push-to-deploy for "video2commons-test" automatically, and keep manual deployments for the the three production services.

That makes sense to me! I didn't realize there was a test project. I'll update the patterns soon and work on a 3rd script. I do have a couple of questions.

I noticed there's no test version of video2commons-socketio. Is it used by both production and the testing environment, or is it not used at all by video2commons-test?

Does video2commons-test use the same encoders as video2commons?

Oh, and one other question I forgot. How is the socketio service restarted? Or does it need to be restarted at all. I didn't see any mention of it in the Wikitech documentation.

For 1, I don't remember, I think it uses the same as I don't remember having seen a socketio test account.
For 2, it uses the redis instance as an encoder. It's likely it doesn't work right now as nobody uses it, and I didn't touch it for a very long time. But you can give a try :) (with a small file of course): https://video2commons-test.toolforge.org/

And how to restart the socketio service, mmmm good question!

in the shell history I see I did that last year:

2025-01-19 17:14:52 toolforge webservice --backend=kubernetes node18 start

.github/workflows/encoder-deployment.yml

don-vip · 2026-02-06T19:42:29Z

.github/workflows/deploy-cloudvps-encoders.yml

+          V2C_USERNAME: ${{ secrets.V2C_USERNAME }}
+          V2C_REDIS_PW: ${{ secrets.V2C_REDIS_PW }}
+          V2C_CONSUMER_SECRET: ${{ secrets.V2C_CONSUMER_SECRET }}
+          V2C_CONSUMER_KEY: ${{ secrets.V2C_CONSUMER_KEY }}


These secrets don't exist yet, are you able to create them or do you want me to create them?

I think I should be able to with my permissions. I'll let you know if I run into any problems.

I added the secrets to the repository-level secrets. I don't have access to the environment-level secrets, which is where I assume SSH_PRIVATE_KEY is located. Is this fine?

Also, I set V2C_USERNAME to adminv2c since that's what I saw in the membership requests.

Ah strange, I must have missed something, I would prefer to set all secrets in the environment, I'm checking your permissions

I've set you to maintainer role, is it enough now to have access to env secrets?

I still don't see it. I'm not sure what permission controls the visibility of that section.

OK now you're admin I can't give you more permissions :D Is it working?

That seemed to do it. I'll get those updated here shortly 😅

Add deployment workflows

4c14c4c

Amdrel requested a review from don-vip February 6, 2026 19:30

Update name of private key variable to 'SSH_PRIVATE_KEY'

ff1cb22

don-vip requested changes Feb 6, 2026

View reviewed changes

Create socketio and frontend test deployment workflows

f009e2b

Amdrel changed the title ~~[Draft] Add workflows for video2commons deployment~~ Add workflows for video2commons deployment Feb 7, 2026

Amdrel marked this pull request as ready for review February 7, 2026 00:55

Conversation

Amdrel commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Disclaimers

Uh oh!

don-vip commented Feb 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

don-vip Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Amdrel commented Feb 6, 2026 •

edited

Loading

don-vip Feb 6, 2026 •

edited

Loading