Open
Conversation
siddharthvp
force-pushed
the
js-build
branch
6 times, most recently
from
9520bb8 to
e05e3da
Compare
Collaborator
Author
|
(sorry about the email spam - the build runs very slowly on my local, so I was doing repeated force pushes for testing in CI) |
supertassu
previously approved these changes
Jun 20, 2025
Member
supertassu
left a comment
supertassu
left a comment
There was a problem hiding this comment.
This generally looks good, except for the one thing inline. This seems like a good use case for a multi-stage build instead of pulling Npm in the main image, but I'm fine with this approach as well.
Can you deploy this yourself or should I?
Dockerfile
Outdated
| COPY . /app | ||
|
|
||
| # Build JS assets | ||
| RUN apt update && \ |
Member
There was a problem hiding this comment.
nit: apt-get should be used in favour of apt in scripts
Run `npm run build` while building the container. The compiled artifact is removed from the checked-in code, and added to .gitignore. Bug: T396991 Change-Id: I5dbb1da8561ef44384afe84319eb6dfb168123f8
supertassu
requested changes
Dec 4, 2025
Member
supertassu
left a comment
supertassu
left a comment
There was a problem hiding this comment.
Actually, slight problem: this breaks the local development environment where docker-compose mounts the local folder over the file generated at build time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
npm run buildwhile building the container. The compiled artifact is removed from the checked-in code, and added to .gitignore.Bug: T396991