Update JDK version from 1.8 to 17#1088
Open
mpsijm wants to merge 3 commits intotoolbox4minecraft:masterfrom
Open
Update JDK version from 1.8 to 17#1088mpsijm wants to merge 3 commits intotoolbox4minecraft:masterfrom
mpsijm wants to merge 3 commits intotoolbox4minecraft:masterfrom
Conversation
This was referenced Jan 8, 2022
Open
|
Can someone that knows coding take this app and update it for 1.18 and not let it die? |
|
@legendkiller1 I intend to fork and update this project; no ETA as of yet |
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-shade-plugin</artifactId> | ||
| <version>3.2.4</version> | ||
| <version>3.3.0-SNAPSHOT</version> |
Contributor
There was a problem hiding this comment.
this should just be 3.3.0, no -SNAPSHOT
Author
There was a problem hiding this comment.
Thanks for the heads-up! 😄 That version seems to have been released about a month ago 🙂
|
So is there a fork or whatever for 1.18? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1020 (thanks @Mobmaker55 for making a start with this! 🙂)
This PR updates the build configuration to use Java 17. This makes Amidst work for Minecraft 1.17 and below.
In Minecraft 1.18, world generation has had a large overhaul, and I am not planning to make an attempt to update Amidst to work with this (I have experience with Java, but not with Minecraft internals, unfortunately).
For anyone who wants to use the Java 17 version of Amidst v4.7, I have published the binaries here: https://github.com/mpsijm/amidst/releases/tag/v4.7-java-17