docs: polish bundle — muted-foreground token, getting-started, Neon URL (closes #47)#55
Merged
Merged
Conversation
Three independent accuracy fixes from an independent review:
- Define `--color-muted-foreground` in app/styles/app.css `@theme` so the
`text-muted-foreground` utility used by the starter routes actually renders
(Tailwind v4 emits nothing for an undefined color utility). Verified the
built CSS now emits `.text-muted-foreground{color:var(--color-muted-foreground)}`.
- Align the scaffold-generated README with the scaffold's "Next steps" output:
one command order, and the DATABASE_URL step is now in both.
- Clarify Neon guidance in .env.example and environment.md — with the neon-http
driver the pooled vs. direct endpoint doesn't matter (the -pooler endpoint is
for the WebSocket Pool driver).
Closes #47.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47. Three independent accuracy/polish fixes, plus a
changelog.d/fragment (per the new convention).1. Undefined Tailwind token
app/styles/app.csswas just@import "tailwindcss";with no@theme, so thetext-muted-foregroundutility used in__root.tsx/index.tsx(5 usages) emitted nothing in Tailwind v4 — the text silently fell back to the default color. Defined--color-muted-foregroundin an@themeblock and documented it indocs/agents/styling.md.Verified: the built CSS now emits
.text-muted-foreground{color:var(--color-muted-foreground)}and theoklch(55.6% 0 0)token (vs. nothing before).2. Getting-started consistency
The scaffold-generated README and the scaffold's final "Next steps" output listed different command orders, and the README omitted the
DATABASE_URLstep. Both now readpnpm install→cp .env.example .env(fillDATABASE_URL) →pnpm dev, with the optional E2E browser install moved to an aside.Verified via scaffold dry-run — README and console output now match.
3. Neon URL guidance
db/client.tsuses theneon-httpdriver, but.env.example/environment.mdtold users to copy the pooled string — a distinction that only matters for the WebSocketPooldriver. Clarified that with the HTTP driver either endpoint works.Verification
pnpm preflightgreen (Biome + tsc + 42 tests); production build emits the token rule; scaffold dry-run confirms the README/Next-steps match.changelog:checkpasses with the new fragment.🤖 Generated with Claude Code
Generated by Claude Code