Open
Conversation
Owner
|
I've added some comments, but otherwise the patchset looks fine to me. |
|
It would have been nice to work/merge from our fork. Some of these changes are duplicates. |
Owner
|
Can you create another pull request then? |
|
It's still there? |
Owner
|
I don't get your question, sorry. Elaborate, pls. |
|
The pull request is still there #6. I'm not sure exactly what you would like me to do regarding issuing another pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do lots of fix and tweaks. Check the commits.
Elbandi