Skip to content

Add and remove list testing using Jest#7

Open
tonnytech wants to merge 5 commits intomainfrom
add-remove-test
Open

Add and remove list testing using Jest#7
tonnytech wants to merge 5 commits intomainfrom
add-remove-test

Conversation

@tonnytech
Copy link
Copy Markdown
Owner

Added a test for the add-remove functions

Copy link
Copy Markdown

@rloterh rloterh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tei,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, with a ReadMe that does not conform to the new standardized ReadMe template. Kindly ensure to update your ReadMe to this standardized template, and then request another review.

New ReadMe Template:
image

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Copy link
Copy Markdown

@Ismailco Ismailco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @teitonny,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

cr-approve

Highlights

✔️ No linter errors
✔️ Used Github Flow
✔️ Work documented professionally

Optional suggestions

  • [OPTIONAL] Kindly consider customizing your README more so it looks professional and descriptive
    Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants