Skip to content

List structure of the project#1

Open
tonnytech wants to merge 7 commits intomainfrom
list-structure
Open

List structure of the project#1
tonnytech wants to merge 7 commits intomainfrom
list-structure

Conversation

@tonnytech
Copy link
Copy Markdown
Owner

@tonnytech tonnytech commented Nov 12, 2022

Did the following in the branch:

  1. Added linters, stylint and eslint configuration
  2. setup webpack
  3. created a list structure of the project using HTML, CSS, and javascript.

Copy link
Copy Markdown

@jerryowusu jerryowusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @teitonny

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

clap approve

Highlights

All linters are passing ✔️
Good commit messages ✔️
Followed GitHub flow ✔️

Optional suggestions

  • [OPTIONAL] kindly consider adding a detailed instruction of how to set up webpack and start the project in your readme file for future reference since it is always difficult to remember some week/months later. Trust me, your future self will thank you. 😉

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants