Skip to content

Use consistent _parquet suffix in GDF parquet driver functions #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanjmcdougall merged 3 commits into from
Feb 25, 2026
Merged

Use consistent _parquet suffix in GDF parquet driver functions #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df669f1
Initial plan
Copilot Feb 23, 2026
a65f481
Rename pin_write_gdf_parquet to pin_write_gdf_geoparquet for consiste…
Copilot Feb 23, 2026
32b8696
Use _parquet suffix consistently: rename pin_read_gdf_geoparquet to p…
Copilot Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/geopins/drivers/gdf/dispatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from geopins.drivers.exceptions import raise_driver_not_supported
from geopins.drivers.gdf.filetypes.gpkg import pin_read_gdf_gpkg, pin_write_gdf_gpkg
from geopins.drivers.gdf.filetypes.parquet import (
pin_read_gdf_geoparquet,
pin_read_gdf_parquet,
pin_write_gdf_parquet,
)
from geopins.drivers.infer import infer_driver_info
Expand Down Expand Up @@ -74,7 +74,7 @@ def _pin_read_gdf(
if filetype == "gpkg":
return pin_read_gdf_gpkg(board=board, **kwargs)
elif filetype == "parquet":
return pin_read_gdf_geoparquet(board=board, **kwargs)
return pin_read_gdf_parquet(board=board, **kwargs)
else:
raise_driver_not_supported(filetype, cls=board.__class__, mode="read")
raise AssertionError # Change to assert_never after deprecating 3.11 support
Expand Down
2 changes: 1 addition & 1 deletion src/geopins/drivers/gdf/filetypes/parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from pins.meta import Meta


def pin_read_gdf_geoparquet(
def pin_read_gdf_parquet(
name: str,
version: str | None = None,
hash: str | None = None, # noqa: A002
Expand Down