Skip to content

Conversation

@jeshecdom
Copy link
Contributor

Closes #1466.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed Fift docs update; I’ve left one inline suggestion in languages/fift/basic-values.mdx to align the metadata with the existing conventions—please apply the inline suggestion.

Comment on lines +1 to +4
---
title: "Basic values"
sidebarTitle: "Basic values"
noindex: "true"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] noindex frontmatter value is incorrectly quoted as a string

In the frontmatter of the new languages/fift/basic-values.mdx page, the noindex key is set to the string "true" instead of the boolean true. The extended documentation style guide describes noindex: true as a supported boolean key and does not show quoted string values for this field, so this deviates from the documented convention for frontmatter metadata. Using a string here can cause inconsistencies in downstream tooling that expects a boolean and may parse or filter on this flag. Aligning this usage with the style guide helps keep frontmatter semantics consistent and predictable across the docs.

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really an issue? I see that many pages use "true" as value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fift > Basic Values]

2 participants