fix(release): CSCore-Restore im Release-Workflow nachziehen#119
Merged
tomtastisch merged 3 commits intomainfrom Feb 22, 2026
Merged
fix(release): CSCore-Restore im Release-Workflow nachziehen#119tomtastisch merged 3 commits intomainfrom
tomtastisch merged 3 commits intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a release-blocking build failure in the release.yml workflow caused by missing NuGet package restore for the out-of-solution FileClassifier.CSCore project. The CSCore project is intentionally kept outside the solution file but is built via custom MSBuild targets in FileTypeDetectionLib.vbproj. When using --no-restore with solution-level builds, the CSCore project's dependencies were not restored, causing NETSDK1004 errors.
Changes:
- Added explicit restore step for
src/FileClassifier.CSCore/FileClassifier.CSCore.csprojin theversion-policyjob ofrelease.yml - Positioned the new restore step between the solution restore and build steps, following the established pattern from
codeql.yml - Uses the same
--locked-modeflag for deterministic dependency resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ziel & Scope
v6.1.13beheben:NETSDK1004im Release-Workflow durch fehlenden Restore des out-of-solution Projektssrc/FileClassifier.CSCore/FileClassifier.CSCore.csproj..github/workflows/release.ymlbegrenzt.Umgesetzte Aufgaben (abhaken)
22279237542via Failed-Logs verifiziert.version-policyden SchrittRestore CSCore (out-of-solution)ergänzt.src/**unverändert).Nachbesserungen aus Review (iterativ)
Security- und Merge-Gates
codex/fix/release-cscore-restore.fix(release): ....security/code-scanning/toolsvor Merge bei0 offene Alerts.Evidence (auditierbar)
gh run view 22279237542 --repo tomtastisch/FileClassifier --log-failed.ci-preflight(FAIL: Pflichtsektion fehlt: ## Ziel & Scope) analysiert.git diff main...HEAD -- .github/workflows/release.yml.actionlint .github/workflows/release.yml(Exit0).DoD (mindestens 2 pro Punkt)
.github/workflows/release.ymlenthältRestore CSCore (out-of-solution)v6.1.13passiert den Build ohneNETSDK1004gh run view+ PR-Checks nachvollziehbar