Skip to content

Comments

fix(release): CSCore-Restore im Release-Workflow nachziehen#119

Merged
tomtastisch merged 3 commits intomainfrom
codex/fix/release-cscore-restore
Feb 22, 2026
Merged

fix(release): CSCore-Restore im Release-Workflow nachziehen#119
tomtastisch merged 3 commits intomainfrom
codex/fix/release-cscore-restore

Conversation

@tomtastisch
Copy link
Owner

@tomtastisch tomtastisch commented Feb 22, 2026

Ziel & Scope

  • Release-Blocker für v6.1.13 beheben: NETSDK1004 im Release-Workflow durch fehlenden Restore des out-of-solution Projekts src/FileClassifier.CSCore/FileClassifier.CSCore.csproj.
  • Scope strikt auf .github/workflows/release.yml begrenzt.

Umgesetzte Aufgaben (abhaken)

  • Root-Cause des fehlgeschlagenen Release-Runs 22279237542 via Failed-Logs verifiziert.
  • In version-policy den Schritt Restore CSCore (out-of-solution) ergänzt.
  • Reihenfolge beibehalten: Restore -> Build -> Tests -> Pack -> Gates.
  • Keine Änderung an Runtime-/Produktcode (src/** unverändert).

Nachbesserungen aus Review (iterativ)

  • PR-Beschreibung auf Governance-Pflichtsektionen umgestellt.
  • Sicherheits-/Merge-Gates explizit dokumentiert.
  • Evidence-Kommandos vollständig angegeben.
  • DoD-Matrix mit auditierbaren Prüfpunkten ergänzt.

Security- und Merge-Gates

  • Branch-Namensschema erfüllt: codex/fix/release-cscore-restore.
  • PR-Titel-Schema erfüllt: fix(release): ....
  • Fail-closed beibehalten: Release stoppt weiterhin bei Gate-Fehlern.
  • Pflichtaussage: security/code-scanning/tools vor Merge bei 0 offene Alerts.

Evidence (auditierbar)

  • Fehlernachweis: gh run view 22279237542 --repo tomtastisch/FileClassifier --log-failed.
  • Governance-Fehlernachweis aus Artifact ci-preflight (FAIL: Pflichtsektion fehlt: ## Ziel & Scope) analysiert.
  • Änderungsnachweis: git diff main...HEAD -- .github/workflows/release.yml.
  • Syntaxcheck lokal: actionlint .github/workflows/release.yml (Exit 0).

DoD (mindestens 2 pro Punkt)

Punkt DoD A DoD B
Release-Workflow-Blocker beseitigt .github/workflows/release.yml enthält Restore CSCore (out-of-solution) Release-Workflow für v6.1.13 passiert den Build ohne NETSDK1004
Scope/Auditierbarkeit Diff beschränkt sich auf eine Workflow-Datei Failure- und Fix-Evidence sind über gh run view + PR-Checks nachvollziehbar

Copilot AI review requested due to automatic review settings February 22, 2026 14:45
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions bot added area:pipeline fix Bugfix impl:config versioning:patch Fix/Refactor/Docs/CI/Tooling; requires PATCH bump labels Feb 22, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a release-blocking build failure in the release.yml workflow caused by missing NuGet package restore for the out-of-solution FileClassifier.CSCore project. The CSCore project is intentionally kept outside the solution file but is built via custom MSBuild targets in FileTypeDetectionLib.vbproj. When using --no-restore with solution-level builds, the CSCore project's dependencies were not restored, causing NETSDK1004 errors.

Changes:

  • Added explicit restore step for src/FileClassifier.CSCore/FileClassifier.CSCore.csproj in the version-policy job of release.yml
  • Positioned the new restore step between the solution restore and build steps, following the established pattern from codeql.yml
  • Uses the same --locked-mode flag for deterministic dependency resolution

Copilot AI review requested due to automatic review settings February 22, 2026 14:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@tomtastisch tomtastisch merged commit 9d5ab40 into main Feb 22, 2026
30 checks passed
@tomtastisch tomtastisch deleted the codex/fix/release-cscore-restore branch February 22, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:pipeline area:tooling fix Bugfix impl:config versioning:patch Fix/Refactor/Docs/CI/Tooling; requires PATCH bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant