Skip to content

Comments

release(core): PR-108-Audit wiederherstellen und Version-SSOT auf 6.0.0 stabilisieren#116

Open
tomtastisch wants to merge 17 commits intomainfrom
codex/release/pr108-audit-final-6-0-0
Open

release(core): PR-108-Audit wiederherstellen und Version-SSOT auf 6.0.0 stabilisieren#116
tomtastisch wants to merge 17 commits intomainfrom
codex/release/pr108-audit-final-6-0-0

Conversation

@tomtastisch
Copy link
Owner

@tomtastisch tomtastisch commented Feb 21, 2026

Ziel & Scope

Diese PR stellt die nach dem Revert/Branch-Neuaufsetzen verloren gegangene Audit-Evidenz wieder her und stabilisiert die aktive Versions-SSOT bewusst auf 6.0.0 (pipeline-kompatibel), ohne neue Feature- oder API-Änderungen einzuführen.

Umgesetzte Aufgaben (abhaken)

  • Neuer sauberer Branch nach Governance-Schema (codex/release/...) von main erstellt.
  • PR-108-Review-Audit als Evidenzdokument wiederhergestellt: docs/governance/047_PR_108_REVIEW_AUDIT_DE.MD.
  • Vollständiger Wiederumsetzungsnachweis gegen PR108-Dateimenge (70 Dateien) ergänzt: keine fehlenden Dateien, keine verlorenen Refactor-Artefakte.
  • Versions-SSOT auf aktive 6.0.0 konvergiert:
    • Directory.Build.props (RepoVersion)
    • src/FileTypeDetection/FileTypeDetectionLib.vbproj (Version, PackageVersion)
    • docs/versioning/002_HISTORY_VERSIONS.MD (Top-Eintrag)
  • EN-Parität für Versionshistorie/Changelog hergestellt (102_..., 103_...).
  • Changelog-Topordnung angepasst: 6.0.0 aktiv, 6.0.1 als nachgelagerte Nachversionierung dokumentiert.
  • Lokale Versioning-SVT-Blockade durch altes NuGet-Artefakt behoben (6.0.1.nupkg aus SVT-Pfad ausgeschlossen, neues 6.0.0.nupkg erzeugt).
  • Build/Test/API-Contract erneut ausgeführt und evidencebasiert protokolliert.
  • Preflight-Kernchecks (Governance/Policy/Doku/Format/CI-Graph) lokal grün nachgewiesen.

Nachbesserungen aus Review (iterativ)

  • PR-108 Thread-Status erneut verifiziert: 53 Threads, unresolved=0 (GitHub GraphQL).
  • Vollständige Audit-Matrix mit Commit-/Thread-Evidenz wieder eingeführt (047_PR_108_REVIEW_AUDIT_DE.MD).
  • PR108-Dateiabgleich dokumentiert (file_count=70, missing_count=0, Threadstatus 53/53 resolved).
  • Versionierungszustand für diesen PR absichtlich auf 6.0.0 fixiert (Folge-PR für Nachversionierung bleibt möglich).
  • SVT-Fehlerbild reproduziert und geschlossen: altes 6.0.1-Artefakt im lokalen artifacts/nuget war Ursache.

Security- und Merge-Gates

  • SECURITY.md unverändert (Repo-Contract eingehalten).
  • Keine neue Dependency eingeführt.
  • Fail-closed Verhalten unverändert; nur Dokumentations-/Versionierungs-Konvergenz + Audit-Evidence.
  • security/code-scanning/tools bleibt Merge-Blocker und muss auf 0 offene Alerts stehen.

Evidence (auditierbar)

Verwendete Kernbefehle:

  • dotnet restore --locked-mode FileClassifier.sln -v minimal
  • dotnet build FileClassifier.sln --no-restore -warnaserror -v minimal
  • dotnet test FileClassifier.sln --no-build -v minimal
  • dotnet test tests/FileTypeDetectionLib.Tests/FileTypeDetectionLib.Tests.csproj -c Release --no-restore --filter "Category=ApiContract" -v minimal
  • bash tools/ci/check-versioning-svt.sh --repo-root . --naming-ssot tools/ci/policies/data/naming.json --versioning-ssot tools/ci/policies/data/versioning.json --out artifacts/refactor_evidence/versioning-svt-summary.json
  • ROOT_DIR=. OUT_DIR=artifacts/refactor_evidence/version-convergence REQUIRE_REMOTE=0 bash tools/versioning/verify-version-convergence.sh
  • bash tools/audit/verify-security-claims.sh
  • gh pr view 108 --json files,mergeCommit + Dateiexistenz-/Diff-Abgleich gegen aktuellen Branch (4badf0f..HEAD)
  • lokaler Preflight-Kernlauf (Label/Governance/Code-Scanning-Tools-Zero/CodeQL-Default-Setup/Doku-Checks/Policy-RoC/Format/CI-Graph)

Artefakte:

  • artifacts/refactor_evidence/restore.log
  • artifacts/refactor_evidence/build.log
  • artifacts/refactor_evidence/test.log
  • artifacts/refactor_evidence/api-contract.log
  • artifacts/refactor_evidence/versioning-svt-direct.log
  • artifacts/refactor_evidence/version-convergence-direct.log
  • artifacts/refactor_evidence/security-claims.log
  • artifacts/refactor_evidence/preflight-local.log
  • artifacts/refactor_evidence/pack.log

DoD (mindestens 2 pro Punkt)

Punkt DoD A DoD B
PR-108 Audit wiederhergestellt Datei docs/governance/047_PR_108_REVIEW_AUDIT_DE.MD vorhanden Thread-Bilanz dokumentiert (UMGESETZT/ASSUMPTION/OFFEN)
Versions-SSOT aktiv auf 6.0.0 RepoVersion == Version == PackageVersion == 6.0.0 Top-Eintrag in docs/versioning/002_HISTORY_VERSIONS.MD ist 6.0.0
Build/Test-Stabilität dotnet build grün dotnet test grün inkl. ApiContract-Filter
Versioning/SVT-Konvergenz check-versioning-svt.sh grün verify-version-convergence.sh (REQUIRE_REMOTE=0) grün
Policy/Preflight lokal dotnet format --verify-no-changes grün CI-Graph + Doku-/Policy-Checks grün

Assumption / Folge-PR

ASSUMPTION: Eine Nachversionierung auf 6.0.1 oder 6.1.x wird in einem Folge-PR separat entschieden, um diese PR auf den pipeline-stabilen Konvergenzstand 6.0.0 zu begrenzen.
Verifikation für Folge-PR: API-Surface-Diff + Contract-Tests + SemVer-Entscheidungsprotokoll.

Copilot AI review requested due to automatic review settings February 21, 2026 22:05
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@tomtastisch
Copy link
Owner Author

@copilot review

Copy link

Copilot AI commented Feb 21, 2026

@tomtastisch I've opened a new pull request, #117, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions github-actions bot added feature New compatible feature or datatype impl:config versioning:minor New compatible functionality; requires MINOR bump labels Feb 21, 2026
@tomtastisch
Copy link
Owner Author

Evidenz-Update: Wiederumsetzung gegen PR108 vollständig verifiziert.

  • PR108 Dateimenge: 70 Dateien (GitHub API, mergeCommit 4badf0f002174dd324cd029295f781b5cbb034e3).
  • Existenzabgleich im aktuellen Branch: missing_count=0.
  • Diff auf PR108-Dateimenge (4badf0f..HEAD): nur Versionierungs-/Dokumentationskonvergenz, keine verlorenen Core-/Hashing-/Infrastructure-Refactor-Dateien.
  • Threadstatus PR108: 53/53 resolved, davon 44 Threads mit Kommentar von @tomtastisch.

Umsetzung/Nachweis im Repo: Commit e6cd639 in docs/governance/047_PR_108_REVIEW_AUDIT_DE.MD.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a deliberate version rollback from 6.0.1 to 6.0.0 to stabilize the repository's version Single Source of Truth (SSOT). Additionally, it restores audit documentation from PR-108 that was lost during a branch reset. The PR explicitly documents that version 6.0.1 work is deferred to a follow-up PR, focusing this release solely on establishing a stable, pipeline-compatible 6.0.0 baseline.

Changes:

  • Rolled back all version references from 6.0.1 to 6.0.0 across property files and project files
  • Restored comprehensive PR-108 review audit documentation with 53 tracked threads
  • Reordered version history and changelog documents to position 6.0.0 as the active version with 6.0.1 documented as deferred/planned work

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
Directory.Build.props Rolled back RepoVersion from 6.0.1 to 6.0.0
src/FileTypeDetection/FileTypeDetectionLib.vbproj Rolled back Version and PackageVersion from 6.0.1 to 6.0.0
docs/versioning/002_HISTORY_VERSIONS.MD Updated working state to 6.0.0 and reordered version table to show 6.0.0 before deferred 6.0.1
docs/versioning/102_HISTORY_VERSIONS.MD Updated working state to 6.0.0 and reordered version table to show 6.0.0 before deferred 6.0.1 (EN)
docs/versioning/003_CHANGELOG_RELEASES.MD Reordered changelog to place 6.0.0 section first, with 6.0.1 documented as deferred patch
docs/versioning/103_CHANGELOG_RELEASES.MD Reordered changelog to place 6.0.0 section first, with 6.0.1 documented as deferred patch (EN)
docs/governance/047_PR_108_REVIEW_AUDIT_DE.MD Added comprehensive audit documentation for PR-108 with full thread tracking and resolution evidence

@tomtastisch
Copy link
Owner Author

CI-Reparatur (1 Commit / 1 Ursache):

  • Ursache: docs-links-full fail wegen gekürzter Plain-URLs mit Unicode-Ellipse () in docs/governance/047_PR_108_REVIEW_AUDIT_DE.MD (nicht parsebar für den Link-Checker).
  • Reparatur-Commit: 389bab9 (fix(docs): normalize truncated URLs in PR-108 audit matrix).
  • Verifikation lokal: python3 tools/check-docs.py => Doc check OK.

Copilot AI review requested due to automatic review settings February 21, 2026 22:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

docs/versioning/103_CHANGELOG_RELEASES.MD:12

  • In the changelog, the internal hashing service is referenced as EvidenceHashingIo, but the implementation/type name in the codebase is EvidenceHashingIO (uppercase IO). This mismatch makes the entry hard to grep/verify and looks like a typo; please align the identifier in the changelog to the actual type name.
  - New internal hashing services (`EvidenceHashingCore`, `EvidenceHashingRoundTrip`, `EvidenceHashingIo`) for deterministic extraction without adding dependencies.
- Changed:

Copilot AI review requested due to automatic review settings February 22, 2026 07:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs area:versioning feature New compatible feature or datatype impl:config versioning:minor New compatible functionality; requires MINOR bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants