Get rid of unnecessary methods brought by using Struct as superclass#7
Closed
marcinwyszynski wants to merge 1 commit intotomstuart:masterfrom
marcinwyszynski:master
Closed
Get rid of unnecessary methods brought by using Struct as superclass#7marcinwyszynski wants to merge 1 commit intotomstuart:masterfrom marcinwyszynski:master
marcinwyszynski wants to merge 1 commit intotomstuart:masterfrom
marcinwyszynski:master
Conversation
Author
|
Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
Contributor
|
Hmm. And what about Many and Eventually? Maybe change them, too? |
Owner
|
I believe this is superseded by #10, so I’m closing it for now. |
Author
|
This is correct, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figured that out when I wanted to use
firstas a valid method name on something I had wrapped inMonads::Optional.