Conversation
gf3
commented
May 28, 2015
- Indicate whether a value can properly respond to a message
|
Sorry, I had notifications turned off, so I only just noticed this. This overlaps with #2, but your implementation is different. Which one is right? |
spec/monads/optional_spec.rb
Outdated
There was a problem hiding this comment.
I would rather see expect(optional).to respond_to :challenge here, assuming that works.
There was a problem hiding this comment.
oh dang, i didn't even know there was a matcher for that. will update
* Indicate whether a value can properly respond to a message
|
@tomstuart updated the test. i don't think the |
|
@gf3 Thanks. What would the corresponding tests look like for |
|
@tomstuart ahh, i suppose we'd have to apply the |
|
@gf3 Well, that’s what |
|
@tomstuart oh my mistake—i thought it also re-wrapped values. |
|
@tomstuart the other PR is correct then |
|
@gf3 It does — I’m being a bit flippant. I just mean that this implementation needs to work across all monads, so it’s going to have to use |
|
This change is superseded by #10, so I’m closing it. |