Solving an issue with isBinomial#1
Open
alexandru-iosif wants to merge 5 commits intotom111:masterfrom
Open
Conversation
added 5 commits
October 12, 2018 15:27
…on enter an infinite loop. Fixing another minor error. Adding a test.
…Basis independet of if the Groebner free method was providing a binomial basis.
… variety of the ideal contained only one point, the function monomialParameterization was trying to find variables for the monomial Parameterization, and this was resulting in an error. Now it returns a more meaningfull error.
…pears much earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that in the case of inhomogeneous ideals isBinomial was computing a Groebner basis even if the Groebner free method was providing a binomial basis. I added just one line to solve this problem, by providing an extra case with a return. I would like to add this change to your repository. Thank you!