Replace immediatelyStartBreaks with configurable automaticallyStartBreaks delay#413
Open
fabienbouchez wants to merge 1 commit intotom-james-watson:masterfrom
Open
Conversation
fabienbouchez
force-pushed
the
feat/automatic-breaks-control
branch
3 times, most recently
from
11dea21 to
0768fce
Compare
fabienbouchez
force-pushed
the
feat/automatic-breaks-control
branch
from
0768fce to
f05db99
Compare
Author
|
Hi Hi @tom-james-watson 👋 Would you mind taking a look at this PR when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds user control over automatic break start by replacing the binary "Immediately start breaks" option with a flexible system featuring configurable delays. Users can now customize when their breaks start automatically (this was hard coded to 120 seconds).
Settings Migration
immediatelyStartBreaks: truesetting are automatically converted toautomaticallyStartBreaks: trueandautomaticallyStartBreaksDelaySeconds: 0(immediate start)