Skip to content

Conversation

@floitsch
Copy link
Member

No description provided.

@floitsch floitsch requested a review from kasperl October 25, 2025 13:21
Copy link
Member

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/file.toit Outdated
/**
Searches for an executable file with the given $name in the system PATH.
Returns null if no such executable is found.
Returns the path as provided by the PATH. For example, if the PATH contains
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Returns the path as provided by the PATH." is difficult to understand. The example is fine. Maybe something like:

Returns a path relative to the part of the PATH where the executable file is found.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@floitsch floitsch enabled auto-merge (squash) October 29, 2025 10:54
@floitsch floitsch merged commit b1fd801 into main Oct 29, 2025
7 checks passed
@floitsch floitsch deleted the floitsch/find-executable branch October 29, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants