Merged
Conversation
timofeev1995
force-pushed
the
egor/lora-dropout
branch
from
183d0b1 to
cae49ed
Compare
timofeev1995
requested review from
artek0chumak and
mryab
and removed request for
mryab
artek0chumak
approved these changes
Jun 9, 2025
Contributor
|
Don't forget to bump up the version before merging! |
sbassam
reviewed
Jun 9, 2025
| f"LoRA adapters are not supported for the selected model ({model_or_checkpoint})." | ||
| ) | ||
|
|
||
| if lora_dropout is not None: |
Contributor
There was a problem hiding this comment.
this can be simplified to if lora_dropout
sbassam
approved these changes
Jun 9, 2025
Contributor
sbassam
left a comment
sbassam
left a comment
There was a problem hiding this comment.
Just left a few comments but nothing major. LGTM otherwise
Comment on lines
+105
to
+111
| create_finetune_request( | ||
| model_limits=_MODEL_LIMITS, | ||
| model=_MODEL_NAME, | ||
| training_file=_TRAINING_FILE, | ||
| lora=True, | ||
| lora_dropout=lora_dropout, | ||
| ) |
Contributor
There was a problem hiding this comment.
I'm not sure why we need this but if it successfully detects out of range dropouts that's fine with me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines?
Issue: Lora droupout can be set to values outside the 0-1 range
Describe your changes
Add validation to the parameter