Support Shadow Dom#42
Open
jarstelfox wants to merge 4 commits intotoddmotto:masterfrom
Open
Conversation
I was having a help of a time down on node v4 with phantomjs, gulp, karma and the like. Let's use the existing configs, but jsut minimally swap them to modern standards. Right now I am on node 18 and all is workign just fine.
Now fluid vids will work as expected inside or outside a shadow dom. Note: This commit does use getRootNode which likely changes the supported envs. For us, this is not a huge deal and likely could be fixed with a small if check to see if that function is supported.
If it takes time to init a shadow dom, we need to wait to ask for our root node. The most ideal time is at init. This still passes test, but I can see it will also fix the issues we have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having a hell of a time down on older node with phantomjs, gulp, karma, and the like.
Let's use the existing configs, but just minimally swap them to modern standards.
Right now I am on node 18 and all is working just fine.
This pull adds support for working under a shadow dom and even fully tests it.
However, I did drop the travis yaml from our fork, I can add it back as needed.