Skip to content

Conversation

@tony
Copy link
Member

@tony tony commented Dec 7, 2025

Summary

  • Migrate PyPI publishing from API token to OIDC-based Trusted Publisher
  • Enable package attestations for supply chain security
  • Fix deprecated skip_existing parameter

Changes

  • Add permissions block with id-token: write and attestations: write
  • Remove user and password parameters from publish step
  • Add attestations: true to enable cryptographic attestations
  • Change skip_existing to skip-existing (kebab-case)

Setup Required

Before merging, configure the trusted publisher on PyPI:

  1. Visit: https://pypi.org/manage/project/libtmux/settings/publishing/
  2. Add publisher with:
    • Owner: tmux-python
    • Repository: libtmux
    • Workflow: tests.yml

Test plan

  • Configure trusted publisher on PyPI
  • Merge PR
  • Create a release tag to verify publishing works

tony added 2 commits December 7, 2025 15:01
why: Improve security by eliminating stored API tokens and enable package attestations
what:
- Add OIDC permissions (id-token, attestations) to release job
- Remove user/password authentication in favor of trusted publishing
- Enable attestations for supply chain security
- Fix deprecated skip_existing to skip-existing
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.68%. Comparing base (4df1128) to head (e7ab9c5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   45.68%   45.68%           
=======================================
  Files          22       22           
  Lines        2250     2250           
  Branches      360      360           
=======================================
  Hits         1028     1028           
  Misses       1079     1079           
  Partials      143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tony tony merged commit 33af048 into master Dec 7, 2025
14 checks passed
@tony tony deleted the trusted-publisher branch December 7, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants