Skip to content

Update activesupport to 6.0 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EverybodyKurts wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update activesupport to 6.0 #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e64ae72
Update activesupport to 6.0
Sep 30, 2019
2ee691c
Bump up minimum required rubies
Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
language: ruby
rvm:
- 2.2
- 2.3
- 2.4
Copy link

@AlexWayfer AlexWayfer Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to delete these versions? We still can support them, I guess. Ruby 2.2 in unsupported anymore, but 2.3 and 2.4 are supported by MRI.

Copy link
Author

@EverybodyKurts EverybodyKurts Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought activesupport ~> 6.0 requires ruby 2.5 or above.

Copy link

@AlexWayfer AlexWayfer Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I didn't know that.

- jruby-19mode # JRuby in 1.9 mode
- 2.5
- 2.6
- jruby-9.2.6.0
# uncomment this line if your project needs to run something other than `rake`:
script: bundle exec rspec spec
gemfile:
- Gemfile.activesupport51

before_install:
- gem install bundler
- gem install bundler
Copy link

@AlexWayfer AlexWayfer Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not relevant and should be done in separated PR.

4 changes: 0 additions & 4 deletions Gemfile.activesupport51
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions time_difference.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ Gem::Specification.new do |gem|
gem.test_files = gem.files.grep(%r{^(test|spec|features)/})
gem.name = "time_difference"
gem.require_paths = ["lib"]
gem.version = "0.7.0"
gem.version = "1.0.0"
Copy link

@AlexWayfer AlexWayfer Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not relevant and should be done in separated PR/commit.

Copy link
Author

@EverybodyKurts EverybodyKurts Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a breaking change though? I guess I should either keep the gem version or the activesupport version the same. If I bump up active_support to be 6.0, that's a breaking change for people who still want to remain on rails 5.2.

Copy link

@AlexWayfer AlexWayfer Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but for alpha versions (0.y.z) there are breaking changes in minor version, not major. 1.y.z is stable release, it's pretty big move. Please, read https://semver.org/

Copy link
Author

@EverybodyKurts EverybodyKurts Oct 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"MINOR version when you add functionality in a backwards compatible manner"

This wouldn't be backwards compatible for people who wanted to stay on rails 5.2 and not upgrade to rails 6. Upgrading from rails 5 to 6 is a pretty huge move.

Regardless, we could specify the activesupport dependency as >= 5.1, then bump up the minor version and still keep rubies 2.2 to 2.4 in the travis build config.

Copy link

@AlexWayfer AlexWayfer Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant this: https://semver.org/#spec-item-4

0 major version is not regular major version that should be increased with any backwards incompatible change.

Copy link
Author

@EverybodyKurts EverybodyKurts Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest commit to hit master was almost 2 years ago! I think the api is pretty stable now. I guess this gem could be kept to 0.x ad infinitum.

Anyway, would specifying the activesupport as >= 5.1 and keeping the gem version to 0.x satisfy you?

Copy link

@AlexWayfer AlexWayfer Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest commit to hit master was almost 2 years ago! I think the api is pretty stable now. I guess this gem could be kept to 0.x ad infinitum.

Okay, but anyway, I believe that version should be changed in separated commit (with tag) by maintainers.

Anyway, would specifying the activesupport as >= 5.1 and keeping the gem version to 0.x satisfy you?

This is good idea while the gem works with lower versions of dependencies.

gem.license = 'MIT'

gem.add_runtime_dependency('activesupport', '~> 5.1')
gem.add_runtime_dependency('activesupport', '~> 6.0')
gem.add_development_dependency('rspec', '~> 3.7.0')
gem.add_development_dependency('rake')

Expand Down