This repository was archived by the owner on Mar 28, 2020. It is now read-only.
Updated example to use latest deck.js and implemented Caleb's fix for issue #1.#4
Open
nemec wants to merge 2 commits intotmbrggmn:masterfrom
Open
Updated example to use latest deck.js and implemented Caleb's fix for issue #1.#4nemec wants to merge 2 commits intotmbrggmn:masterfrom
nemec wants to merge 2 commits intotmbrggmn:masterfrom
Conversation
for fixing issue tmbrggmn#1. This disables the no-md workaround for embedding HTML in Markdown slides, but any HTML content inside a slide should be left untouched by the converter anyway.
Owner
|
Thanks for the contribution! I'll have a looksy soon (if I can get around to it). |
|
Would now be soon enough? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the slide array is not compiled when beforeInit is run, @saintedlama's no-md fix can't be used. Luckily, embedded HTML content seems to pass through the converter untouched so the example no-md slide renders perfectly.
Compared to the old version the slide text is a little large (it actually makes my browser scroll), but that's a recent change in deck.js:master rather than an issue with my update.