webpack-ify import iframe and update hpke #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
andrewkmin
force-pushed
the
andrew/import-hpke
branch
from
e79cad8 to
4738d3b
Compare
andrewkmin
changed the title
andrewkmin
changed the title
andrewkmin
commented
Nov 21, 2025
| uses: docker/setup-buildx-action@f95db51fddba0c2d1ec667646a06c2ce06100226 # v3.0.0 | ||
| - name: Login to GHCR | ||
| if: github.event_name != 'pull_request' | ||
| # if: github.event_name != 'pull_request' |
Contributor
Author
There was a problem hiding this comment.
TODO: before merge, update and remove.
Collaborator
There was a problem hiding this comment.
What's the reason why you had to comment this out?
Collaborator
There was a problem hiding this comment.
oh. I see. To publish the container, to test it.
andrewkmin
force-pushed
the
andrew/import-hpke
branch
from
4738d3b to
943547b
Compare
ngmihodl
previously approved these changes
Nov 21, 2025
r-n-o
reviewed
Nov 21, 2025
Comment on lines
+202
to
+226
| If testing in a live, non-local environment, you can point containers to a new image as follows: | ||
|
|
||
| ``` | ||
| # Update containers (main + init) to new image | ||
| kubectl --context <context> -n tkhq-frames set image deployment/frames \ | ||
| frames=ghcr.io/tkhq/frames@sha256:<digest> \ | ||
| template-quorum-key=ghcr.io/tkhq/frames@sha256:<digest> |
r-n-o
reviewed
Nov 21, 2025
Collaborator
r-n-o
left a comment
r-n-o
left a comment
There was a problem hiding this comment.
very nice! The only thing left to do is revert the Github workflow to what it was so we don't publish on PRs; otherwise looks great! 🥇
r-n-o
previously approved these changes
Nov 25, 2025
andrewkmin
force-pushed
the
andrew/import-hpke
branch
3 times, most recently
from
6139894 to
4fdd8da
Compare
andrewkmin
force-pushed
the
andrew/import-hpke
branch
2 times, most recently
from
2d9c351 to
2d3a183
Compare
r-n-o
previously approved these changes
Nov 26, 2025
ethankonk
force-pushed
the
andrew/import-hpke
branch
from
2d3a183 to
00e4d09
Compare
ethankonk
force-pushed
the
andrew/import-hpke
branch
from
00e4d09 to
faa897b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: $title
Longer:
We're updating hpke (hard-pinned to 1.7.5). Because more recent versions of hpke use a bifurcated dependency import flow (see https://esm.sh/@hpke/core@1.2.7 vs https://esm.sh/@hpke/core@1.7.5), we figured it's a good time to move builds to use webpack.
In doing so, there are several changes:
index.js(for actually served iframe -- event handlers, etc)standalone.js(for standalone page surfaced at/standalone.html)turnkey-core.js(core logic, cryptography, etc)What we're maintaining:
What's not covered: