Change local storage to session storage for keys #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch embedded key storage from localStorage to sessionStorage in the export-and-sign iframe.
setItemWithExpiry,getItemWithExpiry, andonResetEmbeddedKeynow use sessionStorage instead of localStorageSettings remain in localStorage (non-sensitive, can be shared across tabs)
localStorage is shared across all browser tabs with the same origin, causing embedded keys to leak between tabs. When users open multiple tabs of the same parent website, all iframe instances were sharing the same embedded key, creating a security issue.
Using sessionStorage provides tab isolation. Each tab now has its own isolated embedded key, preventing cross-tab key leakage while maintaining HPKE security properties.
Concerns
Since we are switching to sessionStorage, keys will be lost upon page refresh. Users will have to re-inject bundles after refreshing the page.