Skip to content

fix: CLI build/update/watch now run post-processing (signatures, FTS, flows, communities)#98

Open
igagankalra wants to merge 1 commit intotirth8205:mainfrom
igagankalra:fix/cli-post-processing
Open

fix: CLI build/update/watch now run post-processing (signatures, FTS, flows, communities)#98
igagankalra wants to merge 1 commit intotirth8205:mainfrom
igagankalra:fix/cli-post-processing

Conversation

@igagankalra
Copy link
Copy Markdown

Extract the 4-step post-processing pipeline from tools/build.py into a shared postprocessing.py module and wire it into all CLI entry points so that build, update, and watch produce the same complete graph as the MCP tool.

  • Add code_review_graph/postprocessing.py with run_post_processing()
  • tools/build.py now delegates to run_post_processing() (no duplication)
  • cli.py calls _cli_post_process() after build and update commands
  • watch() accepts on_files_updated callback, invoked after each flush
  • 18 new tests covering all steps, isolation, idempotency, and watch

Closes #93

… flows, communities)

Extract the 4-step post-processing pipeline from tools/build.py into a
shared postprocessing.py module and wire it into all CLI entry points so
that `build`, `update`, and `watch` produce the same complete graph
as the MCP tool.

- Add code_review_graph/postprocessing.py with run_post_processing()
- tools/build.py now delegates to run_post_processing() (no duplication)
- cli.py calls _cli_post_process() after build and update commands
- watch() accepts on_files_updated callback, invoked after each flush
- 18 new tests covering all steps, isolation, idempotency, and watch

Closes tirth8205#93
@igagankalra
Copy link
Copy Markdown
Author

I've put up a focused fix for this issue on my fork: igagankalra:fix/cli-post-processing (main...igagankalra:code-review-graph:fix/cli-post-processing)
Why a separate PR instead of relying on #95
PR #95 incidentally patches build and update as part of a much larger feature PR (10 new CLI subcommands + CommonJS require() parsing — 633 lines). The #93 fix is ~65 lines buried in that diff, and it has a few gaps:

  1. Code duplication — feat: CLI-first expansion — 10 subcommands + CommonJS require() parsing #95 copy-pastes the post-processing logic into cli.py as _run_post_processing(), leaving the original copy in tools/build.py untouched. Two copies that can drift.
  2. Watch mode still broken — feat: CLI-first expansion — 10 subcommands + CommonJS require() parsing #95 doesn't touch watch(), which is the third affected entry point listed in this issue.
  3. No tests for the post-processing path itself.
    What the focused fix does differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI build missing post-processing steps that build_or_update_graph_tool MCP tool includes

1 participant