Skip to content

Add pet status effects#208

Merged
Shuu-37 merged 4 commits intotirem:mainfrom
jquick:jq/pet_statuses
Feb 7, 2026
Merged

Add pet status effects#208
Shuu-37 merged 4 commits intotirem:mainfrom
jquick:jq/pet_statuses

Conversation

@jquick
Copy link
Copy Markdown
Contributor

@jquick jquick commented Jan 28, 2026

Add status icons for pets!

Self buffs will have timers as that is known
Debuff will just show icons as we do not know the time

There are cases when we will miss a debuff (no effect packet with some mob WS) but this should cover a good amount of them.

timers

jquick added 3 commits February 2, 2026 15:29
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
@jquick
Copy link
Copy Markdown
Contributor Author

jquick commented Feb 3, 2026

This looks pretty good. Did some testing last night on bst and drg.

Copy link
Copy Markdown
Collaborator

@Shuu-37 Shuu-37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Well-structured PR that follows existing patterns (mirrors debuffhandler nicely). Clean separation between tracking (petbuffhandler) and rendering (display.lua), and the pet target snap fix is a good catch.

A few minor, non-blocking notes:

petbuffhandler.lua:

  • GetActiveEffects(): if expiryTime is set but remaining is negative (already expired), the effect stays in petEffects until 300s past expiry. Not a bug since it renders as icon-only via the remaining > 0 check, but slightly wasteful.
  • PET_ABILITY_BUFFS table is small (7 entries) so many jug pet self-buffs won't get timers — understood this is a reasonable starting point.

display.lua:

  • maxColumns = 6, maxRows = 1 is hardcoded. Fine in practice since pets rarely have more than 3-4 simultaneous effects.

pettarget.lua:

  • Snap anchor change from bottom to top and the ~= nil fix for falsy-zero are both correct.

@Shuu-37 Shuu-37 merged commit 07b5101 into tirem:main Feb 7, 2026
ferrisaj87 pushed a commit to ferrisaj87/XIUI that referenced this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants