Add pet status effects#208
Merged
Shuu-37 merged 4 commits intotirem:mainfrom Feb 7, 2026
Merged
Conversation
added 3 commits
February 2, 2026 15:29
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
Signed-off-by: jquick <iammazungu@gmail.com>
1316007 to
07fb0e1
Compare
Signed-off-by: jquick <iammazungu@gmail.com>
Contributor
Author
|
This looks pretty good. Did some testing last night on bst and drg. |
Shuu-37
approved these changes
Feb 7, 2026
Collaborator
Shuu-37
left a comment
There was a problem hiding this comment.
Looks good! Well-structured PR that follows existing patterns (mirrors debuffhandler nicely). Clean separation between tracking (petbuffhandler) and rendering (display.lua), and the pet target snap fix is a good catch.
A few minor, non-blocking notes:
petbuffhandler.lua:
GetActiveEffects(): ifexpiryTimeis set butremainingis negative (already expired), the effect stays inpetEffectsuntil 300s past expiry. Not a bug since it renders as icon-only via theremaining > 0check, but slightly wasteful.PET_ABILITY_BUFFStable is small (7 entries) so many jug pet self-buffs won't get timers — understood this is a reasonable starting point.
display.lua:
maxColumns = 6, maxRows = 1is hardcoded. Fine in practice since pets rarely have more than 3-4 simultaneous effects.
pettarget.lua:
- Snap anchor change from bottom to top and the
~= nilfix for falsy-zero are both correct.
ferrisaj87
pushed a commit
to ferrisaj87/XIUI
that referenced
this pull request
Apr 16, 2026
Add pet status effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add status icons for pets!
Self buffs will have timers as that is known
Debuff will just show icons as we do not know the time
There are cases when we will miss a debuff (no effect packet with some mob WS) but this should cover a good amount of them.