Adding TRR for Azure Forged SAML#26
Open
vanvleeta wants to merge 7 commits into
Open
Conversation
mjwhitta
requested changes
May 13, 2026
Contributor
mjwhitta
left a comment
mjwhitta
left a comment
There was a problem hiding this comment.
Bit distracted by family stuff, but didn't want to forget. I'll finish reviewing later.
ineffectivecoder
previously approved these changes
May 14, 2026
ineffectivecoder
left a comment
ineffectivecoder
left a comment
There was a problem hiding this comment.
Other than that parenthesis(Today I learned/remembered singular of parentheses) it looks good to me.
dumpst3rfir3
previously approved these changes
May 22, 2026
Contributor
dumpst3rfir3
left a comment
dumpst3rfir3
left a comment
There was a problem hiding this comment.
Looks great to me. Great work, as always. I had a few minor, nit-picky suggestions (and a couple of spelling corrections, I think).
| - none: validation applied to no domains (the state prior to the Dec 2025 | ||
| update) | ||
|
|
||
| Currently this can only be done via the Graph API: |
Contributor
There was a problem hiding this comment.
What privileges are needed to do this? I assume high level (Global admin, etc.)?
vanvleeta
commented
May 26, 2026
Co-authored-by: Alex Garcia <149016698+dumpst3rfir3@users.noreply.github.com> Co-authored-by: vanvleeta <vanvleet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.