Adding TRR for Azure Domain Trust Modification#25
Open
vanvleeta wants to merge 12 commits into
Open
Conversation
mjwhitta
requested changes
Apr 30, 2026
Contributor
mjwhitta
left a comment
mjwhitta
left a comment
There was a problem hiding this comment.
For the most part this LGTM. There is a broken link, some suggested references, and a few questions that you may or may not be able to answer.
dumpst3rfir3
previously approved these changes
Apr 30, 2026
Contributor
dumpst3rfir3
left a comment
dumpst3rfir3
left a comment
There was a problem hiding this comment.
LGTM as well. I think I just had one ignorable, VERY nit-picky comment.
Co-authored-by: Alex Garcia <149016698+dumpst3rfir3@users.noreply.github.com>
Contributor
|
LGTM other than the linter output. |
mjwhitta
previously approved these changes
May 13, 2026
ineffectivecoder
previously approved these changes
May 14, 2026
ineffectivecoder
left a comment
ineffectivecoder
left a comment
There was a problem hiding this comment.
LGTM, cool technique that I really want to try.
dumpst3rfir3
approved these changes
May 27, 2026
Contributor
dumpst3rfir3
left a comment
dumpst3rfir3
left a comment
There was a problem hiding this comment.
Still looks great to me. Sorry, noticed a couple of more misspelled words, but probably nobody cares about that. It's all about the great info.
UPDATE 5/27/26: Looks like I never clicked submit on this approval - sorry!
|
|
||
| - T1484.002 Domain or Tenant Policy Modification: Trust Modification, which | ||
| includes modifications to federated domains. | ||
| - T1556.007 Modify Authenication Process: Hybrid Identity, which includes trust |
Contributor
There was a problem hiding this comment.
Suggested change
| - T1556.007 Modify Authenication Process: Hybrid Identity, which includes trust | |
| - T1556.007 Modify Authentication Process: Hybrid Identity, which includes trust |
| signing certificate, allowing them to generate tokens for users in the tenant. | ||
|
|
||
| This procedure has the same terminal operation as Procedure A but adds three | ||
| preceeding operations - adding the domain, verifying it, and setting the |
Contributor
There was a problem hiding this comment.
Suggested change
| preceeding operations - adding the domain, verifying it, and setting the | |
| preceding operations - adding the domain, verifying it, and setting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.