Skip to content

fix(i18n): remove duplicate German keys unblocking main's Type Check#2495

Merged
sanil-23 merged 1 commit into
tinyhumansai:mainfrom
sanil-23:fix/i18n-de-dedupe-mcpserver
May 22, 2026
Merged

fix(i18n): remove duplicate German keys unblocking main's Type Check#2495
sanil-23 merged 1 commit into
tinyhumansai:mainfrom
sanil-23:fix/i18n-de-dedupe-mcpserver

Conversation

@sanil-23
Copy link
Copy Markdown
Contributor

@sanil-23 sanil-23 commented May 22, 2026

Summary

  • main has been red on Type Check TypeScript since the German locale landed (Add German locale support #2378): two German chunks contain duplicate object-literal keys, which TypeScript rejects with TS1117.
  • This removes the duplicates so the typecheck passes — unblocking the typecheck/e2e checks on every open PR (they currently inherit this failure).

Problem

TypeScript errors on main (pnpm --filter openhuman-app compile):

  • de-5.ts — the entire settings.mcpServer.* block is defined twice (18 duplicate keys, incl. settings.developerMenu.mcpServer.{title,desc}).
  • de-3.tssubconscious.providerUnavailableTitle and subconscious.providerSettings are each defined twice.

Type Check TypeScript is not a required status check, so #2378 merged red and main has stayed red — failing the typecheck (and the e2e build, which runs tsc) on all subsequent PRs.

Solution

Delete the duplicate occurrences, keeping the canonical, better-translated ones:

  • de-5.ts: drop the second settings.mcpServer.* block (L526–547), keeping the first — which also restores the better German ('Verfügbare Werkzeuge' over 'Verfügbare Tools', 'In die Zwischenablage kopieren' over 'In Zwischenablage kopieren').
  • de-3.ts: drop the second providerUnavailableTitle/providerSettings, keeping 'Unterbewusstsein ist pausiert'.

No keys are lost (each appeared exactly twice). pnpm typecheck passes clean after this change.

Submission Checklist

  • Tests added or updated — N/A: removes duplicate translation keys; behaviour-preserving (each key kept once). Verified via pnpm --filter openhuman-app compile (full typecheck) passing.
  • Diff coverage ≥ 80%N/A: translation-data only (no executable lines).
  • Coverage matrix updated — N/A: no feature change.
  • No new external network dependencies — N/A.
  • Manual smoke checklist — N/A.
  • Linked issue closed — N/A.

Impact

  • Fixes main's own broken Type Check TypeScript; unblocks typecheck + e2e on all open PRs.
  • German UI strings unchanged except where the duplicate shadowed the better translation (now corrected).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Localization
    • Updated German language translations to improve consistency and clarity across the application's user interface.

Review Change Stack

de-5.ts re-defined the entire settings.mcpServer.* block twice (18 duplicate keys); de-3.ts duplicated subconscious.providerUnavailableTitle + providerSettings. TypeScript rejects these with TS1117 (duplicate object literal properties), which has left main's 'Type Check TypeScript' job red since tinyhumansai#2378 (German locale) merged — blocking every PR's typecheck/e2e. Remove the duplicate occurrences, keeping the canonical (better-translated) ones: e.g. 'Verfügbare Werkzeuge' over 'Verfügbare Tools', 'Unterbewusstsein ist pausiert' over 'Unterbewusstsein pausiert'. Full pnpm typecheck passes clean after this.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@sanil-23 sanil-23 requested a review from a team May 22, 2026 14:56
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2922ec2c-8430-4df2-a433-12f02696aeeb

📥 Commits

Reviewing files that changed from the base of the PR and between ed3e453 and 43da6b7.

📒 Files selected for processing (2)
  • app/src/lib/i18n/chunks/de-3.ts
  • app/src/lib/i18n/chunks/de-5.ts
💤 Files with no reviewable changes (2)
  • app/src/lib/i18n/chunks/de-3.ts
  • app/src/lib/i18n/chunks/de-5.ts

📝 Walkthrough

Walkthrough

This PR updates German translation strings in two i18n translation chunks. The subconscious provider unavailability title is refined in de-3.ts, and mascot-related UI entries are added or updated in de-5.ts, including color and library unavailability messaging.

Changes

German Translation Updates

Layer / File(s) Summary
German Translation Text Updates
app/src/lib/i18n/chunks/de-3.ts, app/src/lib/i18n/chunks/de-5.ts
subconscious.providerUnavailableTitle is updated from "Unterbewusstsein pausiert" to "Unterbewusstsein ist pausiert"; mascot-related translation entries (settings.mascot.colorYellow, settings.mascot.libraryUnavailable, settings.mascot.title) are added or updated in the de-5 chunk.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • tinyhumansai/openhuman#2378: German-locale additions that introduced or maintained the de-3 chunk; this PR refines the subconscious.providerUnavailableTitle translation entry.

Suggested labels

working

Suggested reviewers

  • graycyrus

Poem

🐰 A rabbit hops through words with care,
German phrases float through the air,
"Ist pausiert" now rings more true,
Mascot colors—yellow hue,
Translations shine in every tongue! 🌍✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing duplicate German translation keys that were blocking TypeScript type checking in the main branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the working A PR that is being worked on by the team. label May 22, 2026
@sanil-23 sanil-23 merged commit 66b3151 into tinyhumansai:main May 22, 2026
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

working A PR that is being worked on by the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant