fix(i18n): remove duplicate German keys unblocking main's Type Check#2495
Conversation
de-5.ts re-defined the entire settings.mcpServer.* block twice (18 duplicate keys); de-3.ts duplicated subconscious.providerUnavailableTitle + providerSettings. TypeScript rejects these with TS1117 (duplicate object literal properties), which has left main's 'Type Check TypeScript' job red since tinyhumansai#2378 (German locale) merged — blocking every PR's typecheck/e2e. Remove the duplicate occurrences, keeping the canonical (better-translated) ones: e.g. 'Verfügbare Werkzeuge' over 'Verfügbare Tools', 'Unterbewusstsein ist pausiert' over 'Unterbewusstsein pausiert'. Full pnpm typecheck passes clean after this. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR updates German translation strings in two i18n translation chunks. The subconscious provider unavailability title is refined in ChangesGerman Translation Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Summary
mainhas been red onType Check TypeScriptsince the German locale landed (Add German locale support #2378): two German chunks contain duplicate object-literal keys, which TypeScript rejects with TS1117.Problem
TypeScript errors on
main(pnpm --filter openhuman-app compile):de-5.ts— the entiresettings.mcpServer.*block is defined twice (18 duplicate keys, incl.settings.developerMenu.mcpServer.{title,desc}).de-3.ts—subconscious.providerUnavailableTitleandsubconscious.providerSettingsare each defined twice.Type Check TypeScriptis not a required status check, so #2378 merged red andmainhas stayed red — failing the typecheck (and the e2e build, which runstsc) on all subsequent PRs.Solution
Delete the duplicate occurrences, keeping the canonical, better-translated ones:
de-5.ts: drop the secondsettings.mcpServer.*block (L526–547), keeping the first — which also restores the better German ('Verfügbare Werkzeuge'over'Verfügbare Tools','In die Zwischenablage kopieren'over'In Zwischenablage kopieren').de-3.ts: drop the secondproviderUnavailableTitle/providerSettings, keeping'Unterbewusstsein ist pausiert'.No keys are lost (each appeared exactly twice).
pnpm typecheckpasses clean after this change.Submission Checklist
N/A: removes duplicate translation keys; behaviour-preserving (each key kept once). Verified viapnpm --filter openhuman-app compile(full typecheck) passing.N/A: translation-data only (no executable lines).N/A: no feature change.N/A.N/A.N/A.Impact
main's own brokenType Check TypeScript; unblocks typecheck + e2e on all open PRs.🤖 Generated with Claude Code
Summary by CodeRabbit