fix: compute SHA-256 digest at correct image offset for combined binaries#15
Open
deadprogram wants to merge 2 commits intomainfrom
Open
fix: compute SHA-256 digest at correct image offset for combined binaries#15deadprogram wants to merge 2 commits intomainfrom
deadprogram wants to merge 2 commits intomainfrom
Conversation
…ries Parse the ESP image structure to find the actual SHA-256 digest position instead of assuming it is the last 32 bytes of the file. Fixes corrupt image hash errors on ESP32-C3/C5 when flashing combined (bootloader + partition table + app) binaries. Signed-off-by: deadprogram <ron@hybridgroup.com>
…ommands Only use compressed flash writes with the stub loader, matching esptool's default behavior. Skip sending FLASH_END/FLASH_DEFL_END to ROM bootloaders as they cause the bootloader to exit prematurely. Only send flash_begin/ flash_end in Reset() when running via stub. Signed-off-by: deadprogram <ron@hybridgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the computation/storage of SHA-256 digest at correct image offset for combined binaries.
Parse the ESP image structure to find the actual SHA-256 digest position instead of assuming it is the last 32 bytes of the file. Fixes corrupt image hash errors on ESP32-C3/C5 when flashing combined (bootloader + partition table + app) binaries.