Skip to content

Row Progress Indicator#140

Open
risha-b427 wants to merge 4 commits into
tinyfish-io:mainfrom
risha-b427:estimated-time-header
Open

Row Progress Indicator#140
risha-b427 wants to merge 4 commits into
tinyfish-io:mainfrom
risha-b427:estimated-time-header

Conversation

@risha-b427

Copy link
Copy Markdown

What I changed

Added row progress information to the dataset page while a dataset is being generated.

Users can now see:

  • Current generated row count
  • Maximum configured row count
  • Remaining rows to generate

Example:
160 / 250 rows | 90 remaining

Why

While testing dataset generation, I found it difficult to understand overall progress at a glance. The existing UI only showed the current row count, making it unclear how close the dataset was to completion.

Testing

  • Created datasets with different max row counts
  • Verified progress updates as new rows are generated
  • Confirmed remaining row count decreases correctly
  • Verified existing dataset table functionality remains unchanged

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds dataset generation progress metrics to the dataset view page, showing completed rows relative to the configured maximum with an optional remaining-row indicator and time estimate. The cell value component gains explicit full-value tooltips for numeric displays. The dataset creation wizard undergoes extensive JSX and TypeScript formatting refactoring across imports, event handlers, and UI rendering without changing its underlying control flow, data handling, or form validation logic.

Sequence Diagram(s)

No sequence diagrams are required for this PR. The changes are primarily UI display enhancements and formatting refactors without introducing new cross-component interactions or significant control flow modifications.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Row Progress Indicator' directly summarizes the main change: adding progress information to the dataset page showing generated rows, max rows, and remaining rows.
Description check ✅ Passed The description clearly explains what was changed (row progress information), why it was needed (unclear progress visibility), and documents testing performed, all directly related to the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
frontend/app/dataset/[id]/page.tsx (1)

73-76: 💤 Low value

Remove unused estimatedMinutesRemaining computation.

This variable is computed but never rendered or otherwise used in the component. The PR objectives describe displaying row counts but make no mention of a time estimate UI.

🧹 Proposed cleanup
 const isBuilding = dataset?.status === "building";
-
-const estimatedMinutesRemaining =
-  isBuilding && remainingRows > 0
-    ? Math.max(1, Math.ceil(remainingRows / 20))
-    : null;
-
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/app/dataset/`[id]/page.tsx around lines 73 - 76, Remove the unused
time-estimate calculation: delete the computed constant
estimatedMinutesRemaining and any related unused references (the expression
using isBuilding and remainingRows) from the component so dead code is
eliminated; keep isBuilding and remainingRows if they are still used elsewhere,
otherwise also remove their unused declarations/imports to avoid linter
warnings.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@frontend/app/dataset/`[id]/page.tsx:
- Around line 73-76: Remove the unused time-estimate calculation: delete the
computed constant estimatedMinutesRemaining and any related unused references
(the expression using isBuilding and remainingRows) from the component so dead
code is eliminated; keep isBuilding and remainingRows if they are still used
elsewhere, otherwise also remove their unused declarations/imports to avoid
linter warnings.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 99e1fddc-c937-454d-8947-df4e8f32395f

📥 Commits

Reviewing files that changed from the base of the PR and between c299587 and 98d22f7.

⛔ Files ignored due to path filters (2)
  • backend/package-lock.json is excluded by !**/package-lock.json
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • frontend/app/dataset/[id]/page.tsx
  • frontend/app/dataset/new/page.tsx
  • frontend/components/table/CellValue.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant