Row Progress Indicator#140
Conversation
📝 WalkthroughWalkthroughThis PR adds dataset generation progress metrics to the dataset view page, showing completed rows relative to the configured maximum with an optional remaining-row indicator and time estimate. The cell value component gains explicit full-value tooltips for numeric displays. The dataset creation wizard undergoes extensive JSX and TypeScript formatting refactoring across imports, event handlers, and UI rendering without changing its underlying control flow, data handling, or form validation logic. Sequence Diagram(s)No sequence diagrams are required for this PR. The changes are primarily UI display enhancements and formatting refactors without introducing new cross-component interactions or significant control flow modifications. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
frontend/app/dataset/[id]/page.tsx (1)
73-76: 💤 Low valueRemove unused
estimatedMinutesRemainingcomputation.This variable is computed but never rendered or otherwise used in the component. The PR objectives describe displaying row counts but make no mention of a time estimate UI.
🧹 Proposed cleanup
const isBuilding = dataset?.status === "building"; - -const estimatedMinutesRemaining = - isBuilding && remainingRows > 0 - ? Math.max(1, Math.ceil(remainingRows / 20)) - : null; -🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/app/dataset/`[id]/page.tsx around lines 73 - 76, Remove the unused time-estimate calculation: delete the computed constant estimatedMinutesRemaining and any related unused references (the expression using isBuilding and remainingRows) from the component so dead code is eliminated; keep isBuilding and remainingRows if they are still used elsewhere, otherwise also remove their unused declarations/imports to avoid linter warnings.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@frontend/app/dataset/`[id]/page.tsx:
- Around line 73-76: Remove the unused time-estimate calculation: delete the
computed constant estimatedMinutesRemaining and any related unused references
(the expression using isBuilding and remainingRows) from the component so dead
code is eliminated; keep isBuilding and remainingRows if they are still used
elsewhere, otherwise also remove their unused declarations/imports to avoid
linter warnings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 99e1fddc-c937-454d-8947-df4e8f32395f
⛔ Files ignored due to path filters (2)
backend/package-lock.jsonis excluded by!**/package-lock.jsonpackage-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
frontend/app/dataset/[id]/page.tsxfrontend/app/dataset/new/page.tsxfrontend/components/table/CellValue.tsx
What I changed
Added row progress information to the dataset page while a dataset is being generated.
Users can now see:
Example:
160 / 250 rows | 90 remaining
Why
While testing dataset generation, I found it difficult to understand overall progress at a glance. The existing UI only showed the current row count, making it unclear how close the dataset was to completion.
Testing