-
Notifications
You must be signed in to change notification settings - Fork 148
feat: add dataset sharing, public preview page, and import #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
balasiddarthan22
wants to merge
8
commits into
tinyfish-io:main
Choose a base branch
from
balasiddarthan22:feat/share-dataset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
71b1e66
feat: add dataset sharing, public preview page, and import
balasiddarthan22 675e227
fix: address CodeRabbit review comments on share feature
balasiddarthan22 1104417
feat: support cross-instance dataset imports
balasiddarthan22 31f937d
fix: remove duplicate columnValidator and add no-cache to share API r…
balasiddarthan22 22d8304
fix: move share endpoint logic to backend, frontend proxies to it
balasiddarthan22 9022c50
fix: add api to backend import, distinguish 404 vs 502 in share routes
balasiddarthan22 a5ff82a
feat: cross-instance dataset sharing and import
balasiddarthan22 a8b6fba
fix: embed schema in share link for offline fallback and fix btoa uni…
balasiddarthan22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { NextResponse } from "next/server"; | ||
|
|
||
| const CORS = { "Access-Control-Allow-Origin": "*" }; | ||
| const BACKEND_URL = | ||
| process.env.BACKEND_URL ?? | ||
| process.env.NEXT_PUBLIC_BACKEND_URL ?? | ||
| "http://localhost:3501"; | ||
|
|
||
| export async function GET( | ||
| _req: Request, | ||
| { params }: { params: Promise<{ id: string }> }, | ||
| ) { | ||
| const { id } = await params; | ||
| try { | ||
| const res = await fetch(`${BACKEND_URL}/share/${id}`, { | ||
| signal: AbortSignal.timeout(5000), | ||
| }); | ||
| if (res.ok) { | ||
| const data = await res.json(); | ||
| return NextResponse.json(data, { headers: CORS }); | ||
| } | ||
| if (res.status === 404) { | ||
| return NextResponse.json({ error: "Dataset not found" }, { status: 404, headers: CORS }); | ||
| } | ||
| return NextResponse.json({ error: "Upstream service error" }, { status: 502, headers: CORS }); | ||
| } catch { | ||
| return NextResponse.json({ error: "Upstream service error" }, { status: 502, headers: CORS }); | ||
| } | ||
| } | ||
|
|
||
| export async function OPTIONS() { | ||
| return new Response(null, { | ||
| status: 204, | ||
| headers: { | ||
| "Access-Control-Allow-Origin": "*", | ||
| "Access-Control-Allow-Methods": "GET, OPTIONS", | ||
| "Access-Control-Allow-Headers": "Content-Type", | ||
| }, | ||
| }); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.