Add hover tooltips for truncated dataset cell values#135
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR enhances the CellValue component with improved accessibility by adding title attributes to cell value spans. The number type rendering now includes the full string value as a title, and the default fallback rendering unconditionally sets the title attribute instead of only when the string exceeded a character limit. These changes enable browsers to display tooltips with the complete cell content. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/components/table/CellValue.tsx`:
- Around line 67-72: The JSX in the CellValue component's number branch (the
conditional where type === "number") contains a stray semicolon after the
closing </span> which breaks TSX parsing; remove the semicolon so the returned
JSX is valid (ensure the return (...) wrapper and the span element are properly
closed and no extra semicolon is inside the JSX expression in the number branch
of CellValue).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b88fd1e9-43f8-484b-9030-48c9144bd746
📒 Files selected for processing (1)
frontend/components/table/CellValue.tsx
What I changed
I added hover tooltips for dataset table cells so the full value can be viewed when text is truncated.
Why
While testing dataset generation, I noticed that long values, such as URLs, job titles, salary ranges, etc., were getting cut off in the table, making them difficult to read without expanding columns.
Testing