Skip to content

Add hover tooltips for truncated dataset cell values#135

Open
risha-b427 wants to merge 2 commits into
tinyfish-io:mainfrom
risha-b427:hover-table-cells-clean
Open

Add hover tooltips for truncated dataset cell values#135
risha-b427 wants to merge 2 commits into
tinyfish-io:mainfrom
risha-b427:hover-table-cells-clean

Conversation

@risha-b427

Copy link
Copy Markdown

What I changed

I added hover tooltips for dataset table cells so the full value can be viewed when text is truncated.

Why

While testing dataset generation, I noticed that long values, such as URLs, job titles, salary ranges, etc., were getting cut off in the table, making them difficult to read without expanding columns.

Testing

  • Generated datasets with long text values and URLs
  • Confirmed the full value appears on hover
  • Verified existing table behavior remains the same

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 296529b4-818c-467c-931e-ee829ee737e4

📥 Commits

Reviewing files that changed from the base of the PR and between a60b077 and fd9d638.

📒 Files selected for processing (1)
  • frontend/components/table/CellValue.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/components/table/CellValue.tsx

📝 Walkthrough

Walkthrough

This PR enhances the CellValue component with improved accessibility by adding title attributes to cell value spans. The number type rendering now includes the full string value as a title, and the default fallback rendering unconditionally sets the title attribute instead of only when the string exceeded a character limit. These changes enable browsers to display tooltips with the complete cell content.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add hover tooltips for truncated dataset cell values' clearly and directly summarizes the main change in the pull request, matching the implementation in CellValue.tsx which adds title attributes for hover tooltips.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation (truncated values in tables), the solution (hover tooltips), and testing performed, all of which align with the code changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/components/table/CellValue.tsx`:
- Around line 67-72: The JSX in the CellValue component's number branch (the
conditional where type === "number") contains a stray semicolon after the
closing </span> which breaks TSX parsing; remove the semicolon so the returned
JSX is valid (ensure the return (...) wrapper and the span element are properly
closed and no extra semicolon is inside the JSX expression in the number branch
of CellValue).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b88fd1e9-43f8-484b-9030-48c9144bd746

📥 Commits

Reviewing files that changed from the base of the PR and between 625866d and a60b077.

📒 Files selected for processing (1)
  • frontend/components/table/CellValue.tsx

Comment thread frontend/components/table/CellValue.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant