Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion backend/src/env.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,17 @@ function required(name: string): string {
return value;
}

function numberFromEnv(name: string, fallback: number): number {
const raw = process.env[name];
if (!raw) return fallback;
const parsed = Number(raw);
return Number.isFinite(parsed) ? parsed : fallback;
}

export const env = {
CLIENT_ORIGIN: process.env.CLIENT_ORIGIN || "http://localhost:3500",
CONVEX_URL: required("CONVEX_URL"),
PORT: Number(process.env.PORT || "3501"),
PORT: numberFromEnv("PORT", 3501),

// Used by ./convex.ts to call internal Convex functions (e.g. agent-driven
// row inserts). Optional today because no scheduled jobs run yet; required
Expand Down Expand Up @@ -56,4 +63,19 @@ export const env = {
process.env.POSTHOG_HOST ||
process.env.NEXT_PUBLIC_POSTHOG_HOST ||
"https://us.i.posthog.com",

REFRESH_SCHEDULER_ENABLED:
process.env.REFRESH_SCHEDULER_ENABLED !== "false",
REFRESH_SCHEDULER_POLL_MS: numberFromEnv(
"REFRESH_SCHEDULER_POLL_MS",
60_000,
),
REFRESH_SCHEDULER_BATCH_SIZE: numberFromEnv(
"REFRESH_SCHEDULER_BATCH_SIZE",
5,
),
REFRESH_SCHEDULER_STALE_AFTER_MS: numberFromEnv(
"REFRESH_SCHEDULER_STALE_AFTER_MS",
6 * 60 * 60 * 1000,
),
Comment thread
coderabbitai[bot] marked this conversation as resolved.
};
176 changes: 176 additions & 0 deletions backend/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,73 @@ async function runUpdateWorkflowInBackground({
}
}

async function runScheduledUpdateWorkflowInBackground({
input,
run,
authorizedUserId,
logger,
modelConfig,
}: {
input: DatasetContext;
run: UpdateWorkflowRun;
authorizedUserId: string;
logger: FastifyBaseLogger;
modelConfig: {
schemaInference: string;
populateOrchestrator: string;
investigateSubagent: string;
};
}): Promise<void> {
const datasetId = input.datasetId;

try {
const result = await run.start({
inputData: {
...input,
authContext: {
authorizedUserId,
workflowRunId: run.runId,
modelConfig,
},
},
});

logger.info(
{
datasetId,
workflowStatus: result.status,
steps: JSON.stringify(result.steps).slice(0, 2000),
},
"Scheduled update workflow completed",
);

if (result.status !== "success") {
throw new Error(`Workflow ended with status: ${result.status}`);
}

await convex.mutation(internal.datasets.completeScheduledRefreshInternal, {
id: datasetId,
now: Date.now(),
});
} catch (err) {
const lastStatusError = statusErrorMessage(err);
logger.error({ err, datasetId }, "Scheduled update workflow failed");

try {
await convex.mutation(internal.datasets.failScheduledRefreshInternal, {
id: datasetId,
now: Date.now(),
lastStatusError,
});
} catch (statusErr) {
logger.error(
{ err: statusErr, datasetId },
"Failed to record scheduled refresh failure",
);
}
}
}

async function runPopulateWorkflowInBackground({
input,
run,
Expand Down Expand Up @@ -350,6 +417,111 @@ async function runPopulateWorkflowInBackground({
}
}

async function backfillDatasetRefreshSettings(
logger: FastifyBaseLogger,
): Promise<void> {
try {
const result = await convex.mutation(
internal.datasets.backfillRefreshSettings,
{ defaultCadence: "daily" },
);
logger.info(result, "Dataset refresh settings backfill complete");
} catch (err) {
logger.error({ err }, "Dataset refresh settings backfill failed");
throw err;
}
}

function startLocalRefreshScheduler(
logger: FastifyBaseLogger,
): ReturnType<typeof setInterval> | null {
if (!env.REFRESH_SCHEDULER_ENABLED) {
logger.info("Dataset refresh scheduler disabled");
return null;
}

let ticking = false;

async function tick(): Promise<void> {
if (ticking) return;
ticking = true;

try {
const now = Date.now();
const dueDatasets = await convex.query(
internal.datasets.listDueForRefreshInternal,
{
now,
limit: env.REFRESH_SCHEDULER_BATCH_SIZE,
},
);

for (const dueDataset of dueDatasets as Array<{ _id: string }>) {
let run: UpdateWorkflowRun;
try {
run = await updateWorkflow.createRun();
} catch (runErr) {
logger.error(runErr, "Failed to create scheduled update workflow run");
continue;
}

const claim = await convex.mutation(
internal.datasets.claimScheduledRefreshInternal,
{
id: dueDataset._id,
now: Date.now(),
runId: run.runId,
staleAfterMs: env.REFRESH_SCHEDULER_STALE_AFTER_MS,
},
);

if (claim.outcome !== "started") {
logger.debug(
{ datasetId: dueDataset._id, outcome: claim.outcome },
"Skipped scheduled refresh claim",
);
continue;
}

const dataset = claim.dataset;
const { getModelConfig } = await import("./config/models.js");
const modelConfig = await getModelConfig(dataset.ownerId);

void runScheduledUpdateWorkflowInBackground({
input: {
datasetId: dataset.datasetId,
datasetName: dataset.datasetName,
description: dataset.description,
columns: dataset.columns,
},
run,
authorizedUserId: dataset.ownerId,
logger,
modelConfig,
});
}
} catch (err) {
logger.error({ err }, "Dataset refresh scheduler tick failed");
} finally {
ticking = false;
}
}

void tick();
const interval = setInterval(() => {
void tick();
}, env.REFRESH_SCHEDULER_POLL_MS);
logger.info(
{
pollMs: env.REFRESH_SCHEDULER_POLL_MS,
batchSize: env.REFRESH_SCHEDULER_BATCH_SIZE,
staleAfterMs: env.REFRESH_SCHEDULER_STALE_AFTER_MS,
},
"Dataset refresh scheduler started",
);
return interval;
}

const fastify = Fastify({ logger: true });

await fastify.register(fastifyCors, {
Expand All @@ -365,9 +537,13 @@ await fastify.register(fastifyCors, {
// protected routes — see the example block below.
await fastify.register(clerkAuthPlugin);

await backfillDatasetRefreshSettings(fastify.log);
const refreshScheduler = startLocalRefreshScheduler(fastify.log);

// Flush queued PostHog events on graceful shutdown so a SIGTERM mid-flight
// doesn't drop the dataset_ready_email_sent capture from the last request.
fastify.addHook("onClose", async () => {
if (refreshScheduler) clearInterval(refreshScheduler);
await shutdownAnalytics();
});

Expand Down
4 changes: 4 additions & 0 deletions docker-compose.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ services:
# When unset, backend analytics module no-ops.
POSTHOG_KEY: ${NEXT_PUBLIC_POSTHOG_KEY:-}
POSTHOG_HOST: ${NEXT_PUBLIC_POSTHOG_HOST:-https://us.i.posthog.com}
REFRESH_SCHEDULER_ENABLED: ${REFRESH_SCHEDULER_ENABLED:-true}
REFRESH_SCHEDULER_POLL_MS: ${REFRESH_SCHEDULER_POLL_MS:-60000}
REFRESH_SCHEDULER_BATCH_SIZE: ${REFRESH_SCHEDULER_BATCH_SIZE:-5}
REFRESH_SCHEDULER_STALE_AFTER_MS: ${REFRESH_SCHEDULER_STALE_AFTER_MS:-21600000}
depends_on:
convex:
condition: service_healthy
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/dashboard/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ import { useRouter } from "next/navigation";
import { useQuery, useConvexAuth } from "convex/react";
import { useUser, useClerk } from "@clerk/nextjs";
import { api } from "@/convex/_generated/api";
import type { UserResource } from "@clerk/types";
import {
DatasetCard,
type DatasetCardData,
} from "@/components/dataset/DatasetCard";
import { useTheme } from "@/components/ThemeToggle";
import { QuotaBadge } from "@/components/QuotaBadge";
import { EVENTS, track } from "@/lib/analytics";
import type { ProfileUser } from "@/lib/profile-user";

export default function DashboardPage() {
const { isAuthenticated, isLoading } = useConvexAuth();
Expand Down Expand Up @@ -252,7 +252,7 @@ function ProfileMenu({
user,
onSignOut,
}: {
user: UserResource | null | undefined;
user: ProfileUser | null | undefined;
onSignOut: () => void;
}) {
const [open, setOpen] = useState(false);
Expand Down
Loading