fix: show meaningful error messages instead of undefined on build/dev failures#137
Merged
fix: show meaningful error messages instead of undefined on build/dev failures#137
Conversation
gnzjgo
force-pushed
the
fix/131-undefined-build-errors
branch
from
d6b1dd7 to
0bcef0b
Compare
… failures (#131) Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d1b0d-6dca-7013-a8f8-af75363aae7d
gnzjgo
force-pushed
the
fix/131-undefined-build-errors
branch
from
0bcef0b to
06c94a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131
When a build or deploy fails and the API response doesn't include the expected error fields, the CLI was showing
undefinedas the error message. Users had to runTINYBIRD_DEBUG=1 tinybird buildto see the actual error.Changes
devanddeploycommand error handlers when neitherdeploy.errorsnorresult.errorare availableformatErrors()insrc/api/build.tsdefensive againste.errorbeing undefinedTINYBIRD_DEBUG=1as a workaround