Add setter and getter for normal and selected dot size#45
Open
melikaafrakhteh wants to merge 1 commit intotinkoff-mobile-tech:masterfrom
Open
Add setter and getter for normal and selected dot size#45melikaafrakhteh wants to merge 1 commit intotinkoff-mobile-tech:masterfrom
melikaafrakhteh wants to merge 1 commit intotinkoff-mobile-tech:masterfrom
Conversation
Contributor
|
Hi, thank you for your contribution, could you please add changelog record for the change you made? |
Stasssm
reviewed
Sep 22, 2022
| * | ||
| * @param size dot color | ||
| */ | ||
| public void setDotSize(int size) { |
There was a problem hiding this comment.
What is the reason for this feature? Do you need dynamically change dot sizes?
Author
There was a problem hiding this comment.
yes, because I cannot use xml and I have to change the size of dots programmatically in code. The default size is not ok for my slider.
| * @param size dot color | ||
| */ | ||
| public void setDotSize(int size) { | ||
| dotNormalSize = size; |
There was a problem hiding this comment.
seems like you need also change dotMinimumSize, like in constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
To support different sizes for normal and selected dots, I added getter and setter for them.