fix: Use readonly type for languages array.#41
Open
sbaechler wants to merge 3 commits intotinganho:masterfrom
Open
fix: Use readonly type for languages array.#41sbaechler wants to merge 3 commits intotinganho:masterfrom
sbaechler wants to merge 3 commits intotinganho:masterfrom
Conversation
Defining the array argument as readonly allows setting the language array as const. Regular arrays are still allowed as `languages` param. The `readonly` is only applied to within the languages function. Defining the language array as const makes typescript aware of the available languages.
Co-authored-by: MiroslavPetrik <miroslavpetrik@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defining the array argument as readonly allows setting the language array as const.
Regular arrays are still allowed as
languagesparam. Thereadonlyis only applied to within the languages function.Defining the language array as const makes typescript aware of the available languages.
Update: With the change from @MiroslavPetrik at least one language is enforced via the type system.
Fixes #40