Skip to content

Fix path traversal in extract_all #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krippee merged 1 commit into from
Dec 19, 2025
Merged

Fix path traversal in extract_all #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/ruby_lzma/archive/reader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,13 @@ def extract(entry, output_path)
# @param full_paths [Boolean] Whether to preserve full paths (default: true)
def extract_all(output_dir, full_paths: true)
ensure_open
base_dir = File.expand_path(output_dir)

entries.each do |entry|
entry_path = entry.name
entry_path = File.basename(entry_path) unless full_paths

output_path = File.join(output_dir, entry_path)
output_path = safe_extract_path(base_dir, entry_path)

if entry.directory?
FileUtils.mkdir_p(output_path)
Expand Down Expand Up @@ -247,6 +248,17 @@ def inspect

private

def safe_extract_path(base_dir, entry_path)
cleaned = entry_path.to_s.gsub(/\A[\/\\]+/, "")
full_path = File.expand_path(File.join(base_dir, cleaned))

unless full_path.start_with?("#{base_dir}/") || full_path == base_dir
raise Error, "Unsafe path in archive: #{entry_path}"
end

full_path
end

def open_archive
raise Error, "File not found: #{@path}" unless File.exist?(@path)

Expand Down