Skip to content

test: cdk-diff smoke test (do not merge) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timpugh wants to merge 1 commit into from
Closed

test: cdk-diff smoke test (do not merge) #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hello_world/hello_world_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def __init__(
self.encryption_key = kms.Key(
self,
"EncryptionKey",
description=f"KMS key for {stack.stack_name} log groups, Lambda env, AppConfig, and SNS",
description=f"KMS key for {stack.stack_name} log groups, Lambda env, AppConfig, and SNS [cdk-diff smoke test]",
enable_key_rotation=True,
# 90 days is a common compliance-aligned cadence (PCI/HIPAA forks
# default to 90). Rotation is fully managed by AWS — key ID/ARN
Expand Down
2 changes: 1 addition & 1 deletion hello_world/hello_world_audit_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def __init__(
self.encryption_key = kms.Key(
self,
"AuditEncryptionKey",
description=f"KMS key for {self.stack_name} CloudTrail audit logs",
description=f"KMS key for {self.stack_name} CloudTrail audit logs [cdk-diff smoke test]",
enable_key_rotation=True,
rotation_period=Duration.days(90),
removal_policy=removal_policy,
Expand Down
2 changes: 1 addition & 1 deletion hello_world/hello_world_data_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def __init__(self, scope: Construct, construct_id: str, *, retain_data: bool = F
self.encryption_key = kms.Key(
self,
"DataEncryptionKey",
description=f"KMS key for {self.stack_name} DynamoDB",
description=f"KMS key for {self.stack_name} DynamoDB [cdk-diff smoke test]",
enable_key_rotation=True,
rotation_period=Duration.days(90),
removal_policy=removal_policy,
Expand Down
2 changes: 1 addition & 1 deletion hello_world/hello_world_frontend_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def __init__(
frontend_encryption_key = kms.Key(
self,
"FrontendEncryptionKey",
description=f"KMS key for {self.stack_name} S3 bucket and log groups",
description=f"KMS key for {self.stack_name} S3 bucket and log groups [cdk-diff smoke test]",
enable_key_rotation=True,
# See HelloWorldApp.encryption_key for the rationale — automated
# rotation, no dependent redeploys, 90-day compliance baseline.
Expand Down
2 changes: 1 addition & 1 deletion hello_world/hello_world_waf_stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def __init__(self, scope: Construct, construct_id: str, **kwargs: Any) -> None:
waf_encryption_key = kms.Key(
self,
"WafEncryptionKey",
description=f"KMS key for {self.stack_name} provider log group encryption",
description=f"KMS key for {self.stack_name} provider log group encryption [cdk-diff smoke test]",
enable_key_rotation=True,
# See HelloWorldApp.encryption_key for the rationale — automated
# rotation, no dependent redeploys, 90-day compliance baseline.
Expand Down