Remove tokenizer workaround after upstream Core AI Models fix#1
Merged
Conversation
Remove the checked-in tokenizer override files and the README instructions for replacing the generated Gemma tokenizer. The workaround is no longer documented or shipped with the project, which avoids tracking large generated tokenizer artifacts in the repository.
Change the XCRemoteSwiftPackageReference for https://github.com/apple/coreai-models.git to use branch = main (kind = branch) instead of upToNextMajorVersion/minimumVersion 0.1.0. Update related Xcode object IDs for the package/product (CoreAILM) in PBXBuildFile, PBXFrameworksBuildPhase, packageReferences and XCSwiftPackageProductDependency so the project points to the new package reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change applies a fix derived from apple/coreai-models#47. It removes the temporary tokenizer workaround from this repository now that the upstream Core AI Models project includes the relevant fix.
Testing
Manually tested.
Checklist