fix potential NPE#30
Merged
Merged
Conversation
yokofly
reviewed
Mar 11, 2026
Contributor
yokofly
left a comment
yokofly
left a comment
There was a problem hiding this comment.
P2 valid. ClientPool tracks queue slots, not only live Client objects, so GuardedClient::~GuardedClient() still needs to call Release(std::move(client), valid) whenever pool_ is set, even if client == nullptr. Skipping that permanently drops a slot, which can lead to acquire timeouts and the pool-size assert on destruction. Minimal fix: restore if (pool_) here; the same cleanup rule likely also applies to the move-assignment path.
yokofly
reviewed
Mar 11, 2026
yuzifeng1984
force-pushed
the
bugfix/issue-29-fix-npe
branch
from
3483765 to
1e5a820
Compare
yokofly
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #29