Add Dynamic column support (read + pass-through) for Proton native protocol#28
Open
sofiane-soufi wants to merge 1 commit into
Open
Conversation
|
@sofiane-soufi thanks for contributing on this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds first-class
dynamicsupport totimeplus-cppfor Proton read + pass-through use cases.Scope
Dynamiccolumns from Proton over native TCP.ColumnString) without lossy decode/re-encode.append/slice/clone/save/load.Variant/JSONtype support (follow-up PR).What changed
Type system / parser / factory
Type::Code::Dynamic.DynamicType(max_types)with canonical names:dynamicdynamic(max_types=N)Type::CreateDynamic(size_t max_types = 32).dynamicdynamic(max_types=N)0..254, malformed forms throwValidationError).New column implementation
ColumnDynamic:timeplus/columns/dynamic.htimeplus/columns/dynamic.cppV1andV2BASICandCOMPACTshared_varianthandlingAppend,Slice,CloneEmpty,Clear,Reserve,Swap,SizeProton protocol compatibility fixes
100,101,102Variantglobal ordering (lexicographic type-name order, includingshared_variant), preventing read desync.Build/docs/wiring
dynamic.h.Type::Dynamicto unsupportedItemViewwrapper set.Tests
Added/updated tests for parser, types, factory, column behavior, and integration:
ut/type_parser_ut.cppdynamicdynamic(max_types=5)ut/CreateColumnByType_ut.cpput/types_ut.cppGetName()/IsEqual()coverage for Dynamic variantsut/column_dynamic_ut.cppLoadV1Basic/LoadV2Basicut/roundtrip_tests.cpput/CMakeLists.txtcolumn_dynamic_ut.cppValidation run
timeplus-cpp-libbuilds successfully.3.0.16(non-compressed path).