Use relaxed ordering for external stream counters#1176
Open
BharatDeva wants to merge 1 commit into
Open
Conversation
ExternalStreamCounter metrics are plain counters and do not publish or order other data. Use explicit std::memory_order_relaxed for add, set, and snapshot operations to match the existing reset/read methods and avoid unnecessary sequential consistency barriers. Fixes timeplus-io#488. Signed-off-by: BharatDeva <278575558+BharatDeva@users.noreply.github.com>
|
|
Collaborator
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
|
// edit v1: assign->check @BharatDeva |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist:
git diff --checkis clean.proton: starts/endsfor new code in existing community code base? Not applicable, this updates Proton-owned code only.Please write user-readable short description of the changes:
Fixes #488.
ExternalStreamCounteris used for metrics counters. The reset/read methods already usestd::memory_order_relaxed, but add, set, andgetCounters()snapshot operations were still using the default sequentially consistent atomic operations.This PR makes those counter-only operations explicit relaxed atomics as well:
fetch_add(..., std::memory_order_relaxed)for counter incrementsstore(..., std::memory_order_relaxed)for setter methodsload(std::memory_order_relaxed)for the metrics snapshot mapValidation performed locally: