Skip to content

More adaptive defaults for modcheck CLI#24

Merged
tildejustin merged 5 commits intotildejustin:mainfrom
Slackow:main
Jan 28, 2026
Merged

More adaptive defaults for modcheck CLI#24
tildejustin merged 5 commits intotildejustin:mainfrom
Slackow:main

Conversation

@Slackow
Copy link
Copy Markdown

@Slackow Slackow commented Jan 19, 2026

  • Use environment variable INST_DIR directly if available, 100% resistant against spaces in paths
  • Change default category to ssg if instance name contains "ssg"
  • Get version from mmc-pack.json if possible

- avoid some errors when trying to read prism version
- replace printing and exiting with utility method to do both
- print to standard error where appropriate
- printing help function now also exits
@Slackow
Copy link
Copy Markdown
Author

Slackow commented Jan 19, 2026

Just also commited:

  • remove space collapsing args for --path and --instance
  • avoid some errors when trying to read prism/mmc version
  • replace printing and exiting with utility method to do both
  • print to standard error where appropriate
  • printing help function now also exits

include variations of "set-seed" in instance name check
@Slackow
Copy link
Copy Markdown
Author

Slackow commented Jan 26, 2026

last commit added it so that if unspecified, the category is automatically set to ssg if ssg-only mods are detected, this does mean all the fabric.mod.json's are fetched twice atm, it's probably a good idea to add a cache for that

@tildejustin
Copy link
Copy Markdown
Owner

if it matters it matters, but no need to make it complicated if it doesn't

@tildejustin tildejustin self-requested a review January 28, 2026 01:55
@tildejustin tildejustin merged commit 3e1ff1a into tildejustin:main Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants