Skip to content

ci: match all nextgen release branches in GitHub Actions#10549

Open
wuhuizuo wants to merge 1 commit intotikv:masterfrom
wuhuizuo:fix/github-actions-nextgen-branch-pattern
Open

ci: match all nextgen release branches in GitHub Actions#10549
wuhuizuo wants to merge 1 commit intotikv:masterfrom
wuhuizuo:fix/github-actions-nextgen-branch-pattern

Conversation

@wuhuizuo
Copy link
Copy Markdown
Contributor

@wuhuizuo wuhuizuo commented Apr 2, 2026

What problem does this PR solve?

Issue Number: Ref #10560

What is changed and how does it work?

ci(actions): match all nextgen release branches

Replace the hardcoded release-nextgen-20250815 workflow filter with release-nextgen-* in:

  • .github/workflows/pd-tests.yaml
  • .github/workflows/tso-function-test.yaml

This keeps the existing non-nextgen branch coverage unchanged while allowing future nextgen release branches to trigger the same GitHub Actions workflows.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • git diff --check
    • verified only the two workflow branch filters changed
    • confirmed the nextgen workflow branch filters now use release-nextgen-*

Code changes

  • Has the configuration change

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. dco-signoff: no Indicates the PR's author has not signed dco. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 2, 2026

Hi @wuhuizuo. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

📝 Walkthrough

Walkthrough

Updated two GitHub Actions workflows to broaden branch triggers: replaced release-nextgen-20250815 with the wildcard release-nextgen-* for both push and pull_request events in .github/workflows/pd-tests.yaml and .github/workflows/tso-function-test.yaml.

Changes

Cohort / File(s) Summary
GitHub Workflow Branch Trigger Updates
/.github/workflows/pd-tests.yaml, /.github/workflows/tso-function-test.yaml
Replaced the specific branch release-nextgen-20250815 with the wildcard pattern release-nextgen-* in both push.branches and pull_request.branches triggers to expand workflow activation to all nextgen release branches.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Poem

🐰 I hopped through branches, wild and free,
Replaced one name with a shining -,
Now workflows dance on every spring,
Fluffy commits and CI sing,
🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is mostly complete with problem statement, changes explanation, and a checklist. However, a critical required section is missing. Add a GitHub issue link in the 'What problem does this PR solve?' section. The template requires 'Issue Number: Close #xxx' format to properly link and track the issue.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: replacing hardcoded nextgen release branch patterns with wildcards in GitHub Actions workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented Apr 2, 2026

/retest

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 2, 2026

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo wuhuizuo force-pushed the fix/github-actions-nextgen-branch-pattern branch from b759919 to 6ad14de Compare April 2, 2026 12:37
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed and removed dco-signoff: no Indicates the PR's author has not signed dco. do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.95%. Comparing base (319d880) to head (6ad14de).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10549   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files         532      532           
  Lines       71862    71862           
=======================================
  Hits        56741    56741           
- Misses      11094    11095    +1     
+ Partials     4027     4026    -1     
Flag Coverage Δ
unittests 78.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented Apr 3, 2026

/check-issue-triage-complete

@okJiang
Copy link
Copy Markdown
Member

okJiang commented Apr 3, 2026

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 3, 2026
@bufferflies
Copy link
Copy Markdown
Contributor

repeat #10550

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented Apr 3, 2026

repeat #10550

@bufferflies #10550 is expected to merge into nextgen release branch

this one is to avoid to create pull request every time when new nextgen release created.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented Apr 3, 2026

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 7, 2026
@ti-chi-bot ti-chi-bot bot added the approved label Apr 7, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 8, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 8, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-07 02:41:25.495002393 +0000 UTC m=+837690.700362450: ☑️ agreed by rleungx.
  • 2026-04-08 07:38:42.713075429 +0000 UTC m=+941927.918435486: ☑️ agreed by okJiang.

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Apr 9, 2026

/retest

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 9, 2026

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen-2 6ad14de link unknown /test pull-unit-test-next-gen-2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants