docs: support multiple lifecycle and expiration rules per bucket#449
docs: support multiple lifecycle and expiration rules per bucket#449garrensmith wants to merge 2 commits into
Conversation
Update Object Lifecycle Rules and Object Expiration docs to reflect tigrisdata/tigris-os#4229, which raises the per-bucket rule limit from 1 to 10 and adds per-rule IDs and prefix filters. Adds multi-rule examples showing different transitions and expirations per prefix. Assisted-by: Claude Opus 4.7 via Claude Code
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR updates both Object Lifecycle Rules and Object Expiration docs to reflect support for up to 10 rules per bucket, documents the new Confidence Score: 4/5Safe to merge with caution — no new bugs introduced, but two pre-existing P1 issues (stale 2025 dates on both pages) remain unresolved from prior review rounds. All newly added content (10-rule limit, ID/Filter.Prefix docs, multi-rule examples) is correct and well-structured. The score ceiling is 4 because of the unresolved P1 stale-date findings from previous reviews that are still present in both files. Both files still contain the "end of the year 2025" date-based sections whose heading, prose, and JSON Date values all read 2025 — now well in the past. Important Files Changed
Reviews (2): Last reviewed commit: "docs: fix prose date and apply prettier ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| - Each rule may include an `ID` (up to 36 characters). If you omit `ID`, Tigris | ||
| generates one. |
There was a problem hiding this comment.
The PR description notes that desc and *-desc are reserved ID prefixes, but this constraint isn't captured anywhere in the documentation. Users who accidentally use a reserved prefix will receive an unexpected error. Consider adding a note here.
| - Each rule may include an `ID` (up to 36 characters). If you omit `ID`, Tigris | ||
| generates one. |
There was a problem hiding this comment.
Same omission as in object-lifecycle-rules.md — the reserved desc and *-desc ID prefixes mentioned in the PR description are absent from this page's "Things to note" section as well.
- Fix "end of year" example prose in object-lifecycle-rules to match the 2025 heading and JSON Date. - Run prettier to satisfy lint:format check. Assisted-by: Claude Opus 4.7 via Claude Code
|
@greptileai review |
1 participant
Summary
ID(max 36 chars;descand*-descreserved) andFilter.Prefixfor scoping a rule to a subset of objects.logs/→STANDARD_IA,archive/→GLACIER) and per-prefix expirations (tmp/after 1 day,logs/after 30 days).Test plan
npm run devand visually inspect /docs/buckets/object-lifecycle-rules and /docs/buckets/objects-expirationnpm run lintNote
Cursor Bugbot is generating a summary for commit 09387b2. Configure here.